Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-44246 and LPS-44090 #1775

Closed
wants to merge 67 commits into from
Closed

LPS-44246 and LPS-44090 #1775

wants to merge 67 commits into from

Conversation

jonathanmccann
Copy link

No description provided.

ealonso and others added 30 commits March 5, 2014 12:52
@ealonso
LPS-43709 Fix tests
03f6e87
LPS-43709 Reuse serviceContext
4fc9511
@lipusz @brianchandotcom
LPS-44122 SF - Use an array instead of two variables in SearchUtil & …
8178a93 
…Summary - Consistency with 6.2.x
@ealonso @brianchandotcom
LPS-44122 SF
960d2be
@brianchandotcom
LPS-44122 SF
c2f5424
@neilking @brianchandotcom
LPS-44642
fe01ca9
@jbalsas @brianchandotcom
LPS-44402 Prevent tab refresh
8c58b8c
@jbalsas @brianchandotcom
LPS-44402 Add emailFrom definition terms map
e759c17
@jbalsas @brianchandotcom
LPS-44402 Add email definition terms map
1fef704
@jbalsas @brianchandotcom
LPS-44402 Use email_notifications_settings taglib
bc929d1
@jbalsas @brianchandotcom
LPS-44402 Save all settings at once
75db1c0
@jbalsas @brianchandotcom
LPS-44402 Send only one languageId value
875cf1d
@jbalsas @brianchandotcom
LPS-44402 Remove unused key
08835c7
@brianchandotcom
LPS-44402 Format source
010c094
@brianchandotcom
LPS-44827
20f93c9
@brianchandotcom
LPS-44402 SF
596b592
@jbalsas @brianchandotcom
LPS-44405 Prevent tab refresh
65e9623
@jbalsas @brianchandotcom
LPS-44405 Add emailfrom definition terms map
4069d61
@jbalsas @brianchandotcom
LPS-44405 Add email definition terms map
a9ccaef
@jbalsas @brianchandotcom
LPS-44405 Use email_notifications_settings taglib
466d97e
@jbalsas @brianchandotcom
LPS-44405 Save all settings at once
0fcb416
@brianchandotcom
LPS-44405 Source formatting
cb2ca42
@brianchandotcom
LPS-44405 Simplify API because we can obtain the values of certain pa…
239b1eb 
…rameters and we don't need them as parameters
@brianchandotcom
LPS-44405 Simplify API by removing unused parameters
7940a76
@brianchandotcom
LPS-44405 SF
dbb9484
@IstvanD @brianchandotcom
LPS-44657 Adding BaseSearcher
655a98b
@ealonso @brianchandotcom
LPS-44657 SF
3562dbf
@IstvanD @brianchandotcom
LPS-44657 Adapting BookmarksSearcher to generalized searching of models
28c77c1
@IstvanD @brianchandotcom
LPS-44657 Adapting DLSearcher to generalized searching of models
a3e1205
@IstvanD @brianchandotcom
LPS-44657 Adapting JournalSearcher to generalized searching of models
46b7ba3
brianchandotcom and others added 27 commits March 5, 2014 09:02
@brianchandotcom
LPS-44810 SF
8184446
@robertoDiaz @brianchandotcom
LPS-44739 no logic changes - Create a new class to test Comments User…
e2229bc 
… notifications. copy and paste from BUNT.java
@robertoDiaz @brianchandotcom
LPS-44739 Fix a detected issue. We are not setting the notification t…
f5a4d08 
…ype.
@robertoDiaz @brianchandotcom
LPS-44739 Update test logic.
59e0ecc
@robertoDiaz @brianchandotcom
LPS-44739 Extract logic to a reusable class and clean test class.
7698225
@robertoDiaz @brianchandotcom
LPS-44739 Create new methods in service to subscribe to a discussion.
503a1eb
@robertoDiaz @brianchandotcom
LPS-44739 Autogenerated
989e236
@brianchandotcom
LPS-44739 Source formatting
c469836
@brianchandotcom
LPS-44739 Simplify test
5dcbbe1
@brianchandotcom
LPS-44739 Inject dependency
020fb7c
@brianchandotcom
LPS-44739 Autogenerated
9cc04f4
@robertoDiaz @brianchandotcom
LPS-44739 auto sf
795c010
@robertoDiaz @brianchandotcom
LPS-44739 User should not be the default test user
82aed72
@brianchandotcom
LPS-44739 Fix - We are subscribing the wrong user
418703a
@topolik @brianchandotcom
LPS-44781 Exclude default user from users.update.last.login
44a623e
@shuyangzhou @brianchandotcom
LPS-44781 Check static flag first
0e3ff65
@shuyangzhou @brianchandotcom
LPS-44781 Need to respect return value, otherwise the follow usage of…
9ab48fb 
… User will see out of last login info
@brianchandotcom
LPS-44705 Fix bug because we are not using the right name to obtain t…
878ceed 
…he settings
@brianchandotcom
LPS-44650 Just the test was frontported
251d042
@shuyangzhou
LPS-44503 Redo with Servlet 3.0 API
23cb605
@brianchandotcom
LPS-44405 Remove unused var
e295320
@brianchandotcom
LPS-44739 SF
602d890
@brianchandotcom
LPS-44739 SF
5726c35
@BryanEngler @jonathanmccann
LPS-44246 Article URL parameters were incorrect
4f2da41
@BryanEngler @jonathanmccann
LPS-44246 Add method to get article URL
f5c013d
@BryanEngler @jonathanmccann
LPS-44246 Instead of setting the article url inside of sendEmail(), u…
75e8fb9 
…se the new method and pass it to sendEmail()
@BryanEngler @jonathanmccann
LPS-44090 Set articleId and articleURL in serviceContext
b8be0fa
@jonathanmccann jonathanmccann mentioned this pull request Mar 5, 2014
Closed
@hhuijser
Copy link
Owner

hhuijser commented Mar 7, 2014

Sent for further review to Mhan: mhan810#227

@hhuijser hhuijser closed this Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone