forked from liferay/liferay-portal
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] LPS-86545 doAsUserId parameter removed from URL when links to pages belonging to other sites of the portal #3398
Closed
ling-alan-huang
wants to merge
52
commits into
hhuijser:master
from
ling-alan-huang:LPS-86545_20180711
Closed
[TS] LPS-86545 doAsUserId parameter removed from URL when links to pages belonging to other sites of the portal #3398
ling-alan-huang
wants to merge
52
commits into
hhuijser:master
from
ling-alan-huang:LPS-86545_20180711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9897837.
…ved XML characters and due to how StripFilter.processInput scans the HTML document
…l the usages are in the same class
This reverts commit 65fe8ac.
… url is a external url
… that we can preserve the parameters in the request and keep forward rather than sendRedirect
…l to avoid NullPointerException on ci:test
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test |
Sent to Brian for review: brianchandotcom#64832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hhuijser,
I add a additional commit, please refer to the commit message.
Thanks,
Alan