Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds potatorolls.com #1109

Merged
merged 2 commits into from
Apr 30, 2024
Merged

adds potatorolls.com #1109

merged 2 commits into from
Apr 30, 2024

Conversation

jknndy
Copy link
Collaborator

@jknndy jknndy commented Apr 28, 2024

Resolves #1078

@jknndy jknndy marked this pull request as ready for review April 28, 2024 19:49
"yields": "12 servings",
"site_name": "Martin's Famous Potato Rolls and Bread",
"title": "Pineapple Upside Down Sticky Buns",
"total_time": 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem correct; commenting because the source data appears to be in slightly-malformed ISO8601 format (PT20 Mins) - but we do get the expected output here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be only handling up till the space and registering it as a valid input, not necessarily a bad thing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, but it seems that it's due to the upper-case capital M / Mins after the space. And that's OK I think.

Copy link
Collaborator

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@jknndy jknndy merged commit 7021190 into hhursev:main Apr 30, 2024
18 checks passed
@jknndy jknndy deleted the potatorolls branch April 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manufactures site: potatorolls.com
2 participants