Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint in HackfmtFormatter.hack #145

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

alexeyt
Copy link
Contributor

@alexeyt alexeyt commented Apr 11, 2022

Our CI was failing with:

  + hhvm vendor/hhvm/hhast/bin/hhast-lint
  You have made a lambda which forwards all its arguments to a static method or function.
  The order of the parameters is the same as the order of the arguments.
  You could create a function reference instead. -> \escapeshellarg<>
    Linter: DontCreateForwardingLambdas
    Location: /home/runner/work/hack-codegen/hack-codegen/src/HackfmtFormatter.hack:74:6
    Code:
    >      $option ==> \escapeshellarg($option)

on HHVM latest. Apply the change suggested by the linter.

@alexeyt alexeyt merged commit 7339735 into hhvm:main Apr 12, 2022
@alexeyt alexeyt deleted the alexeyt-fix-lint branch April 14, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants