Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split withHeader and withAddedHeader into two methods #27

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Split withHeader and withAddedHeader into two methods #27

merged 2 commits into from
Jun 4, 2018

Conversation

YuryBandarchuk16
Copy link
Contributor

@YuryBandarchuk16 YuryBandarchuk16 commented Jun 1, 2018 •
edited

Fix #1

withHeader and withAddedHeader were not properly typed and accepted a variable of mixed type.

So now these two methods are split into two methods each.

withHeader into:

  • withHeader accepting vec<string>
  • withHeaderLine accepting string

withAddedHeader into:

  • withAddedHeader accepting vec<string>
  • withAddedHeaderLine accepting string

@YuryBandarchuk16 YuryBandarchuk16 changed the title Split withHeader into two methods Split withHeader and withAddedHeader into two methods Jun 1, 2018
fredemmott
fredemmott approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@fredemmott fredemmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the $value doccomments

@YuryBandarchuk16
Copy link
Contributor Author

@fredemmott done

@fredemmott fredemmott merged commit 965c59e into hhvm:master Jun 4, 2018
@fredemmott fredemmott mentioned this pull request Jun 4, 2018
Closed
@fredemmott
Copy link
Contributor

Got some open questions in #28, but they don't need to be resolved as part of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredemmott fredemmott fredemmott approved these changes

@usox usox usox approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YuryBandarchuk16 @fredemmott @usox @facebook-github-bot