support typed user attributes in open source

Summary: Pull Request resolved: #22 Reviewed By: kmeht Differential Revision: D10449743 Pulled By: kmeht fbshipit-source-id: 8b1ab4da123da7c093d9767e75379c5b63b67221
hhvm · Oct 18, 2018 · 444ee60 · 444ee60
1 parent bb8841d
commit 444ee60
Show file tree

Hide file tree

Showing 12 changed files with 15 additions and 14 deletions.
diff --git a/.hhconfig b/.hhconfig
@@ -4,3 +4,4 @@ safe_array = true
 safe_vector_array = true
 unsafe_rx = false
 ignored_paths = [ "vendor/.+/tests/.+" ]
+user_attributes=
diff --git a/tests/HSLUnreleasedGlobalsTest.php b/tests/HSLUnreleasedGlobalsTest.php
@@ -9,10 +9,10 @@
  */
 
 use function Facebook\FBExpect\expect;
-use type Facebook\HackTest\HackTest; // @oss-enable
+use type Facebook\HackTest\{DataProvider, HackTest}; // @oss-enable
 // @oss-disable: use type HackTestCase as HackTest;
 
-<<Oncalls('hack')>>
+// @oss-disable: <<Oncalls('hack')>>
 final class HSLUnreleasedGlobalsTest extends HackTest {
 
   public static function providesIsHackArray(): varray<mixed> {

diff --git a/tests/grapheme/GraphemeIntrospectTest.php b/tests/grapheme/GraphemeIntrospectTest.php
@@ -10,6 +10,7 @@
 
 use namespace HH\Lib\Experimental\Str\Grapheme;
 use function Facebook\FBExpect\expect;
+use type Facebook\HackTest\DataProvider; // @oss-enable
 // @oss-disable: use InvariantViolationException as InvariantException;
 
 final class GraphemeIntrospectTest extends \Facebook\HackTest\HackTest {
@@ -102,4 +103,3 @@ public function testPositionExceptions(): void {
       ->toThrow(InvariantException::class);
   }
 }
-
diff --git a/tests/grapheme/GraphemeSelectTest.php b/tests/grapheme/GraphemeSelectTest.php
@@ -10,6 +10,7 @@
 
 use namespace HH\Lib\Experimental\Str\Grapheme;
 use function Facebook\FBExpect\expect;
+use type Facebook\HackTest\DataProvider; // @oss-enable
 // @oss-disable: use InvariantViolationException as InvariantException;
 
 /**
@@ -74,4 +75,3 @@ public function testExtract(
     expect(Grapheme\extract($string, $offset, $next))->toBeSame($expected);
   }
 }
-
diff --git a/tests/io/PathTest.php b/tests/io/PathTest.php
@@ -12,11 +12,11 @@
 use namespace HH\Lib\Experimental\IO;
 
 use function Facebook\FBExpect\expect;
-use type Facebook\HackTest\HackTest; // @oss-enable
+use type Facebook\HackTest\{DataProvider, HackTest}; // @oss-enable
 use type HH\InvariantException as InvalidRegexException; // @oss-enable
 // @oss-disable: use type HackTestCase as HackTest;
 
-<<Oncalls('hack')>>
+// @oss-disable: <<Oncalls('hack')>>
 final class PathTest extends HackTest {
   public function testAbsolute(): void {
     $relative_path = new IO\Path('foo/bar/baz');

diff --git a/tests/random/PseudoRandomTest.php b/tests/random/PseudoRandomTest.php
@@ -14,7 +14,7 @@
 use type Facebook\HackTest\HackTest; // @oss-enable
 // @oss-disable: use type HackTestCase as HackTest;
 
-<<Oncalls('hack')>>
+// @oss-disable: <<Oncalls('hack')>>
 final class PseudoRandomTest extends HackTest {
   use RandomTestTrait;
 

diff --git a/tests/random/RandomTestTrait.php b/tests/random/RandomTestTrait.php
@@ -11,7 +11,7 @@
 use namespace HH\Lib\{C, Dict, Math, Str, Vec, _Private};
 
 use function Facebook\FBExpect\expect;
-use type Facebook\HackTest\HackTest; // @oss-enable
+use type Facebook\HackTest\{DataProvider, HackTest}; // @oss-enable
 // @oss-disable: use type HackTestCase as HackTest;
 // @oss-disable: use InvariantViolationException as InvariantException;
 

diff --git a/tests/random/SecureRandomTest.php b/tests/random/SecureRandomTest.php
@@ -13,7 +13,7 @@
 use type Facebook\HackTest\HackTest; // @oss-enable
 // @oss-disable: use type HackTestCase as HackTest;
 
-<<Oncalls('hack')>>
+// @oss-disable: <<Oncalls('hack')>>
 final class SecureRandomTest extends HackTest {
   use RandomTestTrait;
 

diff --git a/tests/regex/RegexTest.php b/tests/regex/RegexTest.php
@@ -12,11 +12,11 @@
 use namespace HH\Lib\{C, Regex, Str, Vec};
 
 use function Facebook\FBExpect\expect;
-use type Facebook\HackTest\HackTest; // @oss-enable
+use type Facebook\HackTest\{DataProvider, HackTest}; // @oss-enable
 // @oss-disable: use type HackTestCase as HackTest;
 use type HH\InvariantException as InvariantViolationException; // @oss-enable
 
-<<Oncalls('hack')>>
+// @oss-disable: <<Oncalls('hack')>>
 final class RegexTest extends HackTest {
 
   public static function checkThrowsOnInvalidRegex<T>(

diff --git a/tests/utf8/Utf8IntrospectTest.php b/tests/utf8/Utf8IntrospectTest.php
@@ -10,6 +10,7 @@
 
 use namespace HH\Lib\Experimental\Str\Utf8;
 use function Facebook\FBExpect\expect;
+use type Facebook\HackTest\DataProvider; // @oss-enable
 // @oss-disable: use InvariantViolationException as InvariantException;
 
 final class Utf8IntrospectTest extends \Facebook\HackTest\HackTest {
@@ -137,4 +138,3 @@ public function testIsUtf8(string $string, bool $expected): void {
   }
 
 }
-
diff --git a/tests/utf8/Utf8SelectTest.php b/tests/utf8/Utf8SelectTest.php
@@ -9,6 +9,7 @@
  */
 
 use namespace HH\Lib\Experimental\Str\Utf8;
+use type Facebook\HackTest\DataProvider; // @oss-enable
 use function Facebook\FBExpect\expect;
 // @oss-disable: use InvariantViolationException as InvariantException;
 
@@ -72,4 +73,3 @@ public function testSliceBytes(
     expect(Utf8\slice_bytes($string, $offset, $length))->toBeSame($expected);
   }
 }
-
diff --git a/tests/utf8/Utf8TransformTest.php b/tests/utf8/Utf8TransformTest.php
@@ -11,6 +11,7 @@
 use namespace HH\Lib\Experimental\Str\Utf8;
 use function Facebook\FBExpect\expect;
 use type HH\Lib\Experimental\Str\Encoding;
+use type Facebook\HackTest\DataProvider; // @oss-enable
 // @oss-disable: use InvariantViolationException as InvariantException;
 
 final class Utf8TransformTest extends \Facebook\HackTest\HackTest {
@@ -133,4 +134,3 @@ public function testToEncoding(
   }
 
 }
-