Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Ref<T> to 3.28 #111

Merged
merged 5 commits into from
Jan 27, 2020
Merged

Backport Ref<T> to 3.28 #111

merged 5 commits into from
Jan 27, 2020

Conversation

lexidor
Copy link
Contributor

@lexidor lexidor commented Jan 14, 2020

No description provided.

Copy link
Contributor

@fredemmott fredemmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs testing moving to docker.

The newer conventions state that we should use a version ending in latest
However, this version of HHVM is nolonger supported
There will never be an hhvm 3.28.4
Therefore, I can safely test against hhvm 3.28.3
@fredemmott fredemmott merged commit 5e8cc7c into hhvm:v3.28.x Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants