Add File\leaky_temporary_file()
#181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary file that is not automatically deleted. Name is following the "if it's sometimes necessary but you don't want people to use it, name it something scary" principle :p Adding this based on looking into why some open source Facebook projects (e.g. fbshipit) use PHP IO instead of HSL IO. `File\temporary_file()` should be strongly preferred over this, but sometimes it's needed. Test plan: new unit test Reviewers: atry, hsl, jonjanzen
|
@fredemmott has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bigfootjon
approved these changes
Feb 17, 2022
src/file/leaky_temporary_file.php
Outdated
| * | ||
| * `File\temporary_file()` is **strongly** recommended instead. | ||
| * | ||
| * - If the prefix starts with `.`, it is interpretered relative to the current |
There was a problem hiding this comment.
"interpretered" is fun to say but not a word :P
| expect(\file_exists($tf1->getPath()))->toBeTrue(); | ||
| await $tf2->writeAllAsync('hello'); | ||
| $tf2->close(); | ||
| expect(\file_get_contents($tf2->getPath()))->toEqual('hello'); |
There was a problem hiding this comment.
Maybe annotate this line to say that the file should be leaked here?
Otherwise it's kinda unclear what this is testing
|
@fredemmott has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 15, 2022
Summary: This is a temporary file that is not automatically deleted. Name is following the "if it's sometimes necessary but you don't want people to use it, name it something scary" principle :p Adding this based on looking into why some open source Facebook projects (e.g. fbshipit) use PHP IO instead of HSL IO. `File\temporary_file()` should be strongly preferred over this, but sometimes it's needed. X-link: hhvm/hsl#181 Reviewed By: bigfootjon Differential Revision: D34314199 fbshipit-source-id: 8513311c431861b2dfde9b8242702ef7f7585f5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary file that is not automatically deleted.
Name is following the "if it's sometimes necessary but you don't want
people to use it, name it something scary" principle :p
Adding this based on looking into why some open source Facebook projects
(e.g. fbshipit) use PHP IO instead of HSL IO.
File\temporary_file()should be strongly preferred over this, butsometimes it's needed.
Test plan:
new unit test
Reviewers: atry, hsl, jonjanzen