Rename Condition::succeed and Condition::fail to xsucceed and xfail respectively #186
Conversation
Summary:
It would allow for use cases like this:
```
async function outer(): Awaitable<void> {
await wait_for_notification_async(
async $notifyee ==> {
concurrent {
await async {
await gen_usleep(100);
$notifyee->trySucceed("fast condition");
}
await async {
await gen_usleep(10000000000);
$notifyee->trySucceed("slow condition");
}
}
}
);
}
```
Pull Request resolved: hhvm#185
Reviewed By: fredemmott
Differential Revision: D34903436
Pulled By: Atry
fbshipit-source-id: fbe39b59cccc2dcdbdca0642a5b790dc47e4cf3f
…espectively The new name is more consistent with other HSL API
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @Atry! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
The new name is more consistent with other HSL API