Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加实例参数配置模块 #115

Merged
merged 10 commits into from
Apr 9, 2019
Merged

增加实例参数配置模块 #115

merged 10 commits into from
Apr 9, 2019

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Apr 9, 2019

感谢 @yyukai

  • MysqlEngine新增server_version、get_variables、set_variable三个方法
  • 实例管理新增参数配置模块、目前仅支持MySQL,支持配置参数模板,编辑动态参数,并记录修改历史

MODEL新增两个表

ParamTemplate、ParamHistory

新增三个控制权限

 ('menu_param', '菜单 参数配置'),
 ('param_view', '查看实例参数列表'),
 ('param_edit', '修改实例参数'),

新增依赖
表格编辑 bootstrap-editable

@hhyo hhyo added the enhancement New feature or request label Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #115 into master will increase coverage by 0.59%.
The diff coverage is 91.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage    72.5%   73.09%   +0.59%     
==========================================
  Files          61       61              
  Lines        6314     6516     +202     
==========================================
+ Hits         4578     4763     +185     
- Misses       1736     1753      +17
Impacted Files Coverage Δ
sql/urls.py 100% <ø> (ø) ⬆️
sql/sql_tuning.py 95.94% <100%> (-0.16%) ⬇️
sql/engines/inception.py 86.58% <100%> (ø) ⬆️
sql/admin.py 100% <100%> (ø) ⬆️
sql/engines/tests.py 100% <100%> (ø) ⬆️
sql/models.py 95.9% <100%> (+0.28%) ⬆️
sql/tests.py 100% <100%> (ø) ⬆️
sql/views.py 37.86% <40%> (-0.64%) ⬇️
sql/instance.py 45.37% <83.33%> (+16.23%) ⬆️
sql/engines/mysql.py 93.9% <88.23%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b727563...8ace494. Read the comment docs.

@hhyo hhyo requested a review from LeoQuote April 9, 2019 13:22
@hhyo hhyo added this to In progress in v1.5.0 Apr 9, 2019
@hhyo hhyo changed the title 增加MySQL参数配置模块 增加实例参数配置模块 Apr 9, 2019
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很强,又加了两个功能

@hhyo hhyo merged commit 29c66b0 into master Apr 9, 2019
@hhyo hhyo added this to Done in 需求汇总 via automation Apr 9, 2019
@hhyo hhyo deleted the feature/param_setting branch April 9, 2019 14:49
@hhyo hhyo moved this from In progress to Done in v1.5.0 Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v1.5.0
  
Done
需求汇总
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants