审计功能增强 #1342
Merged
审计功能增强 #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
- Coverage 75.54% 75.40% -0.14%
==========================================
Files 81 81
Lines 12548 12624 +76
==========================================
+ Hits 9479 9519 +40
- Misses 3069 3105 +36
Continue to review full report at Codecov.
|
看是否需要在extra中记录设备等信息，同时关于不存在的账号登录操作是否也有必要记录到数据库中，这块因为无法锁定可能存在风险 |
扩展成这样？ 不存在的账号登录操作不记录会导致个信息缺失。是否是因为DDOS的考虑呢？限制登录接口的访问频率似乎更好 |
考虑应该都是内网环境使用，加入地理信息没有太多用 |
hhyo
requested changes
Jan 19, 2022
sql/audit_log.py
Outdated
| @@ -2,6 +2,8 @@ | |||
| import logging | |||
| import datetime | |||
| import simplejson as json | |||
| import geolite2 | |||
hhyo
requested changes
Jan 19, 2022
sql/audit_log.py
Outdated
| now = timezone.now() | ||
| AuditEntry.objects.create(action=u'登入', extra_info=ip, user_id=user.id, user_name=user.username, user_display=user.display, action_time=now) | ||
| AuditEntry.objects.create(action=u'登入', extra_info='|'.join([ip,ua]), user_id=user.id, user_name=user.username, user_display=user.display, action_time=now) |
There was a problem hiding this comment.
加入ua应该要扩充长度了，要不还是恢复前面的记录ip吧😂，我考虑过多了
hhyo
approved these changes
Jan 19, 2022
hhyo
reviewed
Jan 19, 2022
| } | ||
|
|
||
| // 通过前端元素查看确定要绑定事件的对象，有其他更好的实现方式？ | ||
| function downloadAppendOpt(){ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
将审计功能全部抽到一个菜单栏
关联之前的 pr #1251