Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持配置goInception替代Inception审核 #136

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Apr 20, 2019

  • 系统配置页面可选择开启goInception,开启后将会替换Inception的审核和执行
  • 调整部分engine内的column_list获取方法
  • 修改engine中ReviewSet的默认值信息,减少None判断

goInception是基于TiDB的语法解析器,和inpcetion审核工具重构的版本,兼容原Inception的审核规则,并且持续完善中:https://github.com/hanchuanchuan/goInception

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #136 into master will increase coverage by 0.58%.
The diff coverage is 88.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #136      +/-   ##
=========================================
+ Coverage   73.32%   73.9%   +0.58%     
=========================================
  Files          61      62       +1     
  Lines        6533    6683     +150     
=========================================
+ Hits         4790    4939     +149     
- Misses       1743    1744       +1
Impacted Files Coverage Δ
sql/urls.py 100% <ø> (ø) ⬆️
sql/engines/pgsql.py 90.62% <100%> (-2.38%) ⬇️
sql/engines/tests.py 100% <100%> (ø) ⬆️
sql/engines/mssql.py 77.57% <100%> (-0.81%) ⬇️
sql/engines/inception.py 86.92% <100%> (+0.34%) ⬆️
common/tests.py 100% <100%> (ø) ⬆️
sql/engines/models.py 90.36% <100%> (+5.82%) ⬆️
sql/utils/sql_utils.py 100% <100%> (ø) ⬆️
sql/engines/mysql.py 89.77% <46.66%> (-4.32%) ⬇️
common/check.py 80.9% <66.66%> (+17.49%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10196d...62a5b2e. Read the comment docs.

@hhyo hhyo merged commit 3ba2c7f into master Apr 20, 2019
@hhyo hhyo deleted the feature/goinception branch May 26, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant