Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finished mssql data dictionary support #1402

Merged
merged 3 commits into from
Mar 2, 2022
Merged

finished mssql data dictionary support #1402

merged 3 commits into from
Mar 2, 2022

Conversation

quanbisen
Copy link
Collaborator

  遵循软件设计开放闭合原则,把数据字典页面的接口抽离出来,放到EngineBase里,在原有数据字典支持MySQL和Oracle,新增支持MsSQL类型。

@quanbisen
Copy link
Collaborator Author

为啥CI没跑成功?我应该没改其它东西呀。

@hhyo
Copy link
Owner

hhyo commented Feb 25, 2022

https://github.com/hhyo/Archery/runs/5334022985?check_suite_focus=true#step:8:1070

FAIL: test_table_list (sql.tests.TestDataDictionary)

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #1402 (d745284) into master (8e2a196) will decrease coverage by 0.39%.
The diff coverage is 29.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   75.25%   74.86%   -0.40%     
==========================================
  Files          82       82              
  Lines       12938    12998      +60     
==========================================
- Hits         9737     9731       -6     
- Misses       3201     3267      +66     
Impacted Files Coverage Δ
sql/engines/mssql.py 69.89% <11.90%> (-15.82%) ⬇️
sql/engines/mysql.py 80.65% <13.15%> (-10.87%) ⬇️
sql/engines/oracle.py 47.97% <15.78%> (-2.32%) ⬇️
sql/templatetags/format_tags.py 65.00% <33.33%> (-13.58%) ⬇️
sql/engines/__init__.py 69.04% <50.00%> (-2.58%) ⬇️
sql/data_dictionary.py 100.00% <100.00%> (+28.48%) ⬆️
sql/tests.py 98.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2a196...d745284. Read the comment docs.

@quanbisen
Copy link
Collaborator Author

修改了测试用例的返回,可以了。bug我还修复了上次合并支持Oracle类型的页面(当打开MySQL的表信息时,remove了Oracle的表信息页面,当打开Oracle页面时,也把MySQL页面remove了)打开无元素的问题。

@hhyo hhyo merged commit e22d704 into hhyo:master Mar 2, 2022
@quanbisen quanbisen deleted the feature/data_dictionary_mssql_support branch March 2, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants