Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在mysql引擎中，use {db_name} 的语句中增加`` 防止特殊符号问题 #166

Merged
merged 2 commits into from
May 5, 2019
Merged

在mysql引擎中，use {db_name} 的语句中增加`` 防止特殊符号问题 #166

merged 2 commits into from
May 5, 2019

Conversation

LeoQuote
Copy link
Collaborator

@LeoQuote LeoQuote commented May 5, 2019

@LeoQuote LeoQuote requested a review from hhyo May 5, 2019 09:20
@LeoQuote LeoQuote self-assigned this May 5, 2019
@codecov
Copy link

codecov bot commented May 5, 2019 •
edited
Loading

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   73.91%   73.91%           
=======================================
  Files          62       62           
  Lines        6686     6686           
=======================================
  Hits         4942     4942           
  Misses       1744     1744
Impacted Files Coverage Δ
sql/engines/inception.py 86.92% <ø> (ø) ⬆️
sql/engines/goinception.py 88.6% <ø> (ø) ⬆️
sql/engines/mysql.py 89.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbeddc...d45704c. Read the comment docs.

@LeoQuote
Copy link
Collaborator Author

LeoQuote commented May 5, 2019

看了下提交记录， 确实是我写的代码， 我的锅

hhyo
hhyo previously approved these changes May 5, 2019
View reviewed changes
@LeoQuote LeoQuote requested a review from hhyo May 5, 2019 10:21
@LeoQuote LeoQuote merged commit 72c279d into master May 5, 2019
@LeoQuote LeoQuote deleted the bugfix/fix-mysql-dbname-with-symbols branch May 5, 2019 10:28
@LeoQuote
Copy link
Collaborator Author

LeoQuote commented May 5, 2019

刚merge完问完dba sql server的也需要这样处理， 尴尬

@LeoQuote LeoQuote mentioned this pull request May 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhyo hhyo hhyo approved these changes

Assignees

@LeoQuote LeoQuote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeoQuote @hhyo