Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增test_connection方法,用于检测实例连接 #1670

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Jul 10, 2022

关联issue: #694 #1451 #1667

@LeoQuote
Copy link
Collaborator

测试应该可以挪到新的地方去,不用删除吧

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #1670 (1d84467) into master (1f00cd8) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1670      +/-   ##
==========================================
- Coverage   76.23%   76.21%   -0.03%     
==========================================
  Files          91       91              
  Lines       14300    14293       -7     
==========================================
- Hits        10902    10893       -9     
- Misses       3398     3400       +2     
Impacted Files Coverage Δ
common/tests.py 100.00% <ø> (ø)
sql/urls.py 100.00% <ø> (ø)
sql/engines/redis.py 75.92% <25.00%> (-0.49%) ⬇️
sql/engines/__init__.py 67.03% <33.33%> (-3.21%) ⬇️
sql/engines/mongo.py 50.00% <50.00%> (ø)
common/check.py 86.36% <100.00%> (+2.55%) ⬆️
sql/engines/clickhouse.py 71.48% <100.00%> (+0.11%) ⬆️
sql/engines/goinception.py 65.87% <100.00%> (+0.16%) ⬆️
sql/engines/mssql.py 70.20% <100.00%> (+0.15%) ⬆️
sql/engines/mysql.py 82.83% <100.00%> (+0.05%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f00cd8...1d84467. Read the comment docs.

@hhyo
Copy link
Owner Author

hhyo commented Jul 10, 2022

测试应该可以挪到新的地方去,不用删除吧

前面没有剔除干净的Inception代码,已经不使用了

@hhyo hhyo merged commit 5cd9048 into master Jul 11, 2022
@hhyo hhyo deleted the test-connection branch July 11, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants