upgrade ace.js==1.15.0 #2045
Merged
upgrade ace.js==1.15.0 #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 75.03% // Head: 75.03% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2045 +/- ##
=======================================
Coverage 75.03% 75.03%
=======================================
Files 102 102
Lines 14809 14809
=======================================
Hits 11112 11112
Misses 3697 3697 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
rebase 下, 解决下 lint 问题 |
Add files via upload Add files via upload
我 rebase 了还是一样，lint 报错的那几个文件，我根本没更新到。 |
|
在这里 #2046 修了, 这个pr 可以安全 merge |
|
前端部分已经测试过了吗? CI 只能跑后端的 |
我没有很严格的测试。文件只更新了ace编辑器。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade ace.js==1.15.0
#375