Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

实例参数管理支持管理inception的参数 #221

Merged
merged 2 commits into from
May 27, 2019

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented May 26, 2019

本次修改需要扩充数据库类型,定义inception/goinception,这也是纠结是否需要合并的原因

  • 使inception和goinception像mysql一样支持动态参数配置

均已更新演示环境

@hhyo hhyo requested a review from LeoQuote May 26, 2019 08:27
@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #221 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   82.02%   82.03%   +<.01%     
==========================================
  Files          64       64              
  Lines        7824     7895      +71     
==========================================
+ Hits         6418     6477      +59     
- Misses       1406     1418      +12
Impacted Files Coverage Δ
sql/views.py 41.84% <0%> (ø) ⬆️
sql/engines/__init__.py 54.54% <0%> (-6.68%) ⬇️
sql/engines/tests.py 99.75% <100%> (ø) ⬆️
sql/utils/resource_group.py 75% <100%> (+1.92%) ⬆️
sql/instance.py 43.94% <100%> (ø) ⬆️
sql/models.py 94.8% <100%> (ø) ⬆️
sql/engines/inception.py 88.62% <81.25%> (-0.86%) ⬇️
sql/engines/goinception.py 91.3% <82.35%> (-2.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a36e99...84d9f63. Read the comment docs.

@hhyo hhyo force-pushed the feature/inception_params_setting branch from 31bb896 to e076271 Compare May 26, 2019 08:38
@LeoQuote
Copy link
Collaborator

感觉没有大毛病,如果你想的话,甚至可以从mysql继承,这样继承出来inception engine

@hhyo hhyo force-pushed the feature/inception_params_setting branch from 455e21d to 84d9f63 Compare May 27, 2019 12:51
@hhyo hhyo merged commit 98165ef into master May 27, 2019
@hhyo hhyo deleted the feature/inception_params_setting branch May 27, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants