Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: 为 failed_login_count 增加范围限制, 强制限制在 0-127 #438

Merged
merged 1 commit into from
Sep 8, 2019

Conversation

LeoQuote
Copy link
Collaborator

@LeoQuote LeoQuote commented Sep 8, 2019

fix #417

@LeoQuote LeoQuote added the bug Something isn't working label Sep 8, 2019
@LeoQuote LeoQuote requested a review from hhyo September 8, 2019 05:00
@LeoQuote
Copy link
Collaborator Author

LeoQuote commented Sep 8, 2019

最近CI 咋这么慢...... 都半小时了还没有 coverage report

@LeoQuote LeoQuote force-pushed the bugfix/failed_login_count-out-range branch from 5b30739 to 559eb57 Compare September 8, 2019 05:51
@LeoQuote LeoQuote force-pushed the bugfix/failed_login_count-out-range branch from 559eb57 to 9127e44 Compare September 8, 2019 05:56
@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage    84.9%   84.93%   +0.02%     
==========================================
  Files          70       70              
  Lines        9104     9121      +17     
==========================================
+ Hits         7730     7747      +17     
  Misses       1374     1374
Impacted Files Coverage Δ
sql/models.py 94.98% <100%> (+0.03%) ⬆️
sql/tests.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0c63e...9127e44. Read the comment docs.

@LeoQuote
Copy link
Collaborator Author

LeoQuote commented Sep 8, 2019

小技巧: 没有报告的时候,rebase 一下,改一下commit 信息然后再强制推送可能就修好了

@LeoQuote LeoQuote merged commit 8b9e146 into master Sep 8, 2019
@LeoQuote LeoQuote deleted the bugfix/failed_login_count-out-range branch November 5, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataError: (1264, "Out of range value for column 'failed_login_count' at row 1")
2 participants