Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update vitest v1 #185

Merged
merged 8 commits into from
Dec 7, 2023
Merged

chore(deps): update vitest v1 #185

merged 8 commits into from
Dec 7, 2023

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Dec 5, 2023

Comment on lines 566 to 577
expect(wrapError(() => jsonExtra.stringify(original, null, 2)))
.toMatchInlineSnapshot(`
{
"ok": false,
"value": [TypeError: Converting circular structure to JSON
--> starting at object with constructor 'Array'
--- index 0 closes the circle"
--- index 0 closes the circle],
}
`);

// TODO: multiline error message doesn't work with "toThrowErrorMatchingInlineSnapshot"?
expect(() => jsonExtra.stringify(original, null, 2)).toThrow();
Copy link
Owner Author

@hi-ogawa hi-ogawa Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unstable snapshot with multiline error message?
It could be a regression from vitest-dev/vitest#4396


Indeed something bad is happening:
https://stackblitz.com/edit/vitest-dev-vitest-fmwjqc?file=test%2Fbasic.test.ts

I raised an issue on Vitest repo

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in upstream vitest-dev/vitest#4663

@hi-ogawa hi-ogawa merged commit 2202378 into main Dec 7, 2023
1 check passed
@hi-ogawa hi-ogawa deleted the chore-vitest branch December 7, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant