Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils-node): cancel stream on error #255

Merged
merged 3 commits into from
May 18, 2024
Merged

fix(utils-node): cancel stream on error #255

merged 3 commits into from
May 18, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented May 18, 2024 •
edited
Loading

I noticed there's another possibility to flip the web/node world.

Readable.fromWeb(response.body).pipe(res)
response.body.pipeTo(Writable.toWeb(res))

Both seems to be working mostly same, but for now let's just go with the former.

@hi-ogawa hi-ogawa marked this pull request as ready for review May 18, 2024 06:00
@hi-ogawa hi-ogawa merged commit e38af9c into main May 18, 2024
3 checks passed
@hi-ogawa hi-ogawa deleted the fix-cancel-stream-on-error branch May 18, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hi-ogawa