Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-server): dynamic import glob routes #278

Closed
wants to merge 3 commits into from

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Apr 10, 2024

Cherry picked from


This will probably make server css crawling to miss on first render, but that's probably not a huge deal. If needed, it should be possible to cover them by more eagerly evaluating module and that's a trade off.

// ensure import analysis is ready for top entries
await Promise.all(entries.map((e) => server.transformRequest(e)));

EDIT: hmm, maybe not. It doesn't look good. For example, navigating from /test to /test/css misses css import and it requires a reload to get styles.


TODO

  • see if it helps cold start (probably not when everything is bundled on edge)
    • doesn't seem so

@hi-ogawa hi-ogawa marked this pull request as ready for review April 10, 2024 03:38
@hi-ogawa hi-ogawa force-pushed the feat-lazy-import-glob-route branch from f05bbfb to d1662cf Compare June 10, 2024 06:34
@hi-ogawa hi-ogawa changed the base branch from main to chore-tweak-tests June 10, 2024 06:34
@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Jun 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa force-pushed the feat-lazy-import-glob-route branch 2 times, most recently from d76a21a to 8f56074 Compare June 10, 2024 06:47
Base automatically changed from chore-tweak-tests to main June 10, 2024 06:53
@hi-ogawa hi-ogawa force-pushed the feat-lazy-import-glob-route branch from 8f56074 to b54273b Compare June 10, 2024 06:54
@hi-ogawa hi-ogawa marked this pull request as draft June 10, 2024 07:09
@hi-ogawa hi-ogawa mentioned this pull request Jul 3, 2024
3 tasks
@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Jul 3, 2024

Superseded by

@hi-ogawa hi-ogawa closed this Jul 3, 2024
@hi-ogawa hi-ogawa deleted the feat-lazy-import-glob-route branch July 3, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant