feat: preload flight data #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
force-pushed
the
feat-preload-flight
branch
from
6b7d3ec
to
dde83bd
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with a simple
<link>based preloading without any client logic. This would be similar to Remix (react-router)'s prefetch https://github.com/remix-run/remix/blob/8a997a62d3e86eced31d4dbf5eddff0b85065e4e/packages/remix-react/components.tsx#L449-L455As I removed
?__rscquery encoding, preload is fetching a full flight data, so it's probably mostly intended for prerendered page.(TODO: probably, I should restore
?__rschashing. if we can preload prerendered page, then it wouldn't be so bad to have slightly higher cache miss at cdn level. Or if we have "prerender manaifest" on client, then it can strip parameter as needed.)todo