fix: partial support of server-client-mixed package + chore: add react-tweet demo #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
hi-ogawa
force-pushed
the
chore-external-server-component-with-client-component-2
branch
from
79a79b5
to
6391d04
Compare
hi-ogawa
force-pushed
the
chore-external-server-component-with-client-component-2
branch
from
d01eb84
to
4a1cd49
Compare
|
commit: @hiogawa/react-server
@hiogawa/react-server-next
@hiogawa/transforms
@hiogawa/vite-plugin-ssr-middleware
|
hi-ogawa
changed the title
hi-ogawa
commented
Jul 15, 2024
Comment on lines
131
to
137
| // when using external library's server component includes client reference, | ||
| // it will end up here with deps optimization hash `?v=` resolved by server module graph. | ||
| // this is not entirely free from double module issue, | ||
| // but it allows handling simple server-client-mixed package such as react-tweet. | ||
| if (!manager.buildType && id.includes("?v=")) { | ||
| id = id.split("?v=")[0]!; | ||
| } |
There was a problem hiding this comment.
I ranted a lot, but probably we can just merge this since we already have similar hack somewhere too and this doesn't make any worse...
hi-ogawa
deleted the
chore-external-server-component-with-client-component-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
?v=(this still causes dual modules when client is imported from both server (no?v=) and client (with?v=)