-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve feature and dependency rendering #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious what if we also keep the color here? For instance:
- Enabled by user: + and colored
- Enabled: colored
- Disable: nothing
Because it seems hard to tell from the picture, which features are included in the features that are turned on by default(or by users).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was confused what you are talking about until I realized that we needed #142 to properly render the new style of output.
Does the new output change your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you.
I am hesitant about whether we should use the symbol "+" or not. This might confuse the users as "+" usually indicates addition. I am uncertain if this will cause any confusion. |
This matches a proposal in rust-lang/cargo#10681 for cargo-add Fixes hi-rustin#26
I'd like to present the three states
Any other thoughts for doing so? Or should we give up and only do required vs optional? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! 👍
I don't have a strong opinion on this. We can release it to see what others think. |
@epage Do you think this PR is ready to go? I am preparing for a new release. |
Yes, it is |
Thanks for working on this again! 🤟 🖤 |
This matches a proposal in rust-lang/cargo#10681 for how to render features in cargo-add.
A bit unsure on the dependency rendering.
Fixes #26