fix(view): Another alternative view #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This primarily is meant to be a simplification so its easier to add / remove content. We can evaluate fancier formatting, like tables, later when we know more of what we want. To simplify my work, I cut fields that I wasn't as sure of including. I also wanted to take a small crack at some formatting changes so the new, plain view was easier to read. Since I was touching formatting, I went ahead and applied my indentation suggestion. This is by no means to say "this is THE design" but I think it helps move us in that direction.
epage
force-pushed
the
layout
branch
3 times, most recently
from
1c8b8cf
to
4d30a2f
Compare
hi-rustin
approved these changes
Nov 16, 2023
| write!(stdout, "{header}version:{reset} {}", package_id.version())?; | ||
| if let Some(latest) = summaries.iter().max_by_key(|s| s.version()) { | ||
| if latest.version() != package_id.version() { | ||
| write!(stdout, " {warn}(latest {}){reset}", latest.version())?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily is meant to be a simplification so its easier to add / remove content.
We can evaluate fancier formatting, like tables, later when we know more of what we want.
To simplify my work, I cut fields that I wasn't as sure of including.
I also wanted to take a small crack at some formatting changes so the new, plain view was easier to read.
Since I was touching formatting, I went ahead and applied my indentation suggestion.
This is by no means to say "this is THE design" but I think it helps move us in that direction.