Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bail out an error for non remote registry #64

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

hi-rustin
Copy link
Owner

@hi-rustin hi-rustin commented Dec 11, 2023

ref #60, #22

This PR only bailed out an error. We need to add this feature later.

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@hi-rustin hi-rustin changed the title WIP: fix: bail out an error for non remote registry fix: bail out an error for non remote registry Dec 11, 2023
@hi-rustin hi-rustin marked this pull request as ready for review December 11, 2023 12:21
Copy link
Owner Author

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check

@hi-rustin hi-rustin merged commit f0d555e into main Dec 11, 2023
9 checks passed
@hi-rustin hi-rustin deleted the rustin-patch-unpublished branch December 11, 2023 12:23
@hi-rustin hi-rustin requested a review from epage December 11, 2023 12:27
Copy link
Collaborator

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely something we ened to figure out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants