feat: allow inspect local workspace packages #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
hi-rustin
commented
Dec 13, 2023
tests/testsuite/cargo_information/within_ws_and_pick_ws_package/stdout.log
Outdated
Show resolved
Hide resolved
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
hi-rustin
force-pushed
the
rustin-patch-ws-pkg
branch
from
a43f067
to
20ffd0e
Compare
epage
reviewed
Dec 13, 2023
epage
reviewed
Dec 13, 2023
tests/testsuite/cargo_information/within_ws_and_pick_ws_package/stdout.log
Outdated
Show resolved
Hide resolved
hi-rustin
force-pushed
the
rustin-patch-ws-pkg
branch
from
1817ea6
to
3e11ca1
Compare
epage
reviewed
Dec 17, 2023
src/ops/info.rs
Outdated
Comment on lines
117
to
121
| // Only suggest cargo tree command when the package is not a workspace member. | ||
| // For workspace members, `cargo tree --package <SPEC> --invert` is useless. It only prints itself. | ||
| let suggest_cargo_tree_command = | ||
| ws_inspect_info.package_id.is_some() && !ws_inspect_info.is_member; | ||
| let add_is_member_note = ws_inspect_info.is_member; |
There was a problem hiding this comment.
Maybe we should generalize this on the PackageId's SourceId's SourceKind.
- If from default registry, do nothing
- If from non-default registry, specify that
- If from git or path, say so
We likely don't care about the level of detail of whether it is a workspace member or not.
There was a problem hiding this comment.
Sounds make sense. Thanks!
hi-rustin
force-pushed
the
rustin-patch-ws-pkg
branch
2 times, most recently
from
b94cdbc
to
4a2ac07
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
hi-rustin
force-pushed
the
rustin-patch-ws-pkg
branch
from
4a2ac07
to
50cf653
Compare
hi-rustin
commented
Dec 17, 2023
| (Some(latest), false) if latest.version() != package_id.version() => { | ||
| write!( | ||
| stdout, | ||
| " {warn}(latest {} {note}from {}{warn}){reset}", |
There was a problem hiding this comment.
I am not sure if this is a good color choice. Do you have any thoughts?
| @@ -1,4 +1,4 @@ | |||
| my-package | |||
| version: 0.4.1+my-package (latest 99999.0.0+my-package) | |||
| version: 0.4.1+my-package (latest 99999.0.0+my-package from registry `dummy-registry`) | |||
There was a problem hiding this comment.
The latest version and source URL.
| @@ -0,0 +1,6 @@ | |||
| cargo-list-test-fixture | |||
| version: 0.2.0 (from [ROOT]/case) | |||
|
@epage I am going to move forward and merge it. If you have any other comments we can improve it later. I want to merge it to avoid conflicts when making some improvements to the MSRV stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The panic occurred while creating the API registry. Simply disregard the error.
close #60