OGM-1111 Iterators will throw NoSuchElementException

hibernate · Dec 16, 2016 · 38ba328 · 38ba328
1 parent c9e991f
commit 38ba328
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/core/src/main/java/org/hibernate/ogm/datastore/map/impl/MapDialect.java b/core/src/main/java/org/hibernate/ogm/datastore/map/impl/MapDialect.java
@@ -11,6 +11,7 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.NoSuchElementException;
 
 import org.hibernate.LockMode;
 import org.hibernate.dialect.lock.LockingStrategy;
@@ -218,7 +219,8 @@ public Tuple next() {
 				next = next( iterator );
 				return current;
 			}
-			return null;
+
+			throw new NoSuchElementException();
 		}
 
 		@Override

diff --git a/...hibernate/ogm/datastore/ehcache/persistencestrategy/kind/impl/OnePerKindCacheManager.java b/...hibernate/ogm/datastore/ehcache/persistencestrategy/kind/impl/OnePerKindCacheManager.java
@@ -7,6 +7,7 @@
 package org.hibernate.ogm.datastore.ehcache.persistencestrategy.kind.impl;
 
 import java.util.Iterator;
+import java.util.NoSuchElementException;
 
 import org.hibernate.ogm.datastore.ehcache.impl.Cache;
 import org.hibernate.ogm.datastore.ehcache.persistencestrategy.common.impl.CacheNames;
@@ -128,9 +129,13 @@ public boolean hasNext() {
 
 		@Override
 		public Tuple next() {
-			Tuple current = createTuple( entityCache.get( this.next ) );
-			this.next = next( this.iterator );
-			return current;
+			if ( hasNext ) {
+				Tuple current = createTuple( entityCache.get( this.next ) );
+				this.next = next( this.iterator );
+				return current;
+			}
+
+			throw new NoSuchElementException();
 		}
 
 		@Override