Add MongoDB + skip by dialect + environment variables for MongoDB #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e mapping for Calendar and Byte for BuiltInTypeTest to pass
… MongoDBTupleSnapshot. fix endsWith check on _id to include . prefix. add ToString on AssociationTupleSnapshot. construct DBObject with size instead of HashMap for columnNames+columnValues.
…_, eg. associations_BlogEntry
…ng MongoDB instance
|
By the way the reason the previous code was not working is because in my system, Environment from ORM reads System properties before the the TestHelper was initialized. I am not sure why but after all nothing is guaranteed wrt class loading and static block calls ordering. |
|
Ok my bad! But not fully understanding it. I know there are no guarantees among static class initialization, but there definitely is an order between a) initialize the class b) use it. |
|
I'm working on merging this one to master :) |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reworked @Sanne environment variables for MongoDB commit.
It should properly work now. Can you review @Sanne ?
The rest is good and you have the +1 from me to apply.