HHH-12492 Test HQL Delete query with a subquery referencing the paren…

…t query's aliases

hibernate-core/src/test/java/org/hibernate/test/hql/DeleteQuerySubqueryReferencingTargetPropertyTest.java

@@ -0,0 +1,83 @@
+package org.hibernate.test.hql;
+
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.Id;
+import javax.persistence.ManyToOne;
+import javax.persistence.Query;
+import javax.persistence.criteria.CriteriaBuilder;
+import javax.persistence.criteria.CriteriaQuery;
+
+import org.hibernate.jpa.test.BaseEntityManagerFunctionalTestCase;
+
+import org.hibernate.testing.FailureExpected;
+import org.hibernate.testing.TestForIssue;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.hibernate.testing.transaction.TransactionUtil.doInJPA;
+
+@TestForIssue(jiraKey = "HHH-12492")
+public class DeleteQuerySubqueryReferencingTargetPropertyTest extends BaseEntityManagerFunctionalTestCase {
+
+	@Override
+	protected Class<?>[] getAnnotatedClasses() {
+		return new Class<?>[] { Master.class, Detail.class };
+	}
+
+	@Test
+	@FailureExpected(jiraKey = "HHH-12492")
+	public void testSubQueryReferencingTargetProperty() {
+		// prepare
+		doInJPA( this::entityManagerFactory, entityManager -> {
+			Master m1 = new Master();
+			entityManager.persist( m1 );
+			Detail d11 = new Detail( m1 );
+			entityManager.persist( d11 );
+			Detail d12 = new Detail( m1 );
+			entityManager.persist( d12 );
+
+			Master m2 = new Master();
+			entityManager.persist( m2 );
+		} );
+
+		doInJPA( this::entityManagerFactory, entityManager -> {
+			// depending on the generated ids above this delete removes all masters or nothing
+			// removal of all masters results in foreign key constraint violation
+			// removal of nothing is incorrect since 2nd master does not have any details
+
+			// DO NOT CHANGE this query: it used to trigger a very specific bug caused
+			// by the alias not being added to the generated query
+			String d = "delete from Master m where not exists (select d from Detail d where d.master=m)";
+			Query del = entityManager.createQuery( d );
+			del.executeUpdate();
+
+			// so check for exactly one master after deletion
+			CriteriaBuilder builder = entityManager.getCriteriaBuilder();
+			CriteriaQuery<Master> query = builder.createQuery( Master.class );
+			query.select( query.from( Master.class ) );
+			Assert.assertEquals( 1, entityManager.createQuery( query ).getResultList().size() );
+		} );
+	}
+
+	@Entity(name = "Master")
+	public static class Master {
+		@Id
+		@GeneratedValue
+		private Integer id;
+	}
+
+	@Entity(name = "Detail")
+	public static class Detail {
+		@Id
+		@GeneratedValue
+		private Integer id;
+
+		@ManyToOne(optional = false)
+		private Master master;
+
+		public Detail(Master master) {
+			this.master = master;
+		}
+	}
+}