Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HHH-11328 : Persist of transient entity in derived ID that is already…
… in merge process throws javax.persistence.EntityExistsException
- Loading branch information
Showing
2 changed files
with
289 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
211 changes: 211 additions & 0 deletions
211
...test/annotations/derivedidentities/bidirectional/CompositeIdDerivedIdWithIdClassTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| /* | ||
| * Hibernate, Relational Persistence for Idiomatic Java | ||
| * | ||
| * License: GNU Lesser General Public License (LGPL), version 2.1 or later. | ||
| * See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>. | ||
| */ | ||
| package org.hibernate.test.annotations.derivedidentities.bidirectional; | ||
|
|
||
| import java.io.Serializable; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Objects; | ||
| import javax.persistence.CascadeType; | ||
| import javax.persistence.Column; | ||
| import javax.persistence.Entity; | ||
| import javax.persistence.Id; | ||
| import javax.persistence.IdClass; | ||
| import javax.persistence.JoinColumn; | ||
| import javax.persistence.ManyToOne; | ||
| import javax.persistence.OneToMany; | ||
|
|
||
| import org.junit.After; | ||
| import org.junit.Test; | ||
|
|
||
| import org.hibernate.Session; | ||
| import org.hibernate.testing.TestForIssue; | ||
| import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| public class CompositeIdDerivedIdWithIdClassTest extends BaseCoreFunctionalTestCase { | ||
| @Override | ||
| protected Class<?>[] getAnnotatedClasses() { | ||
| return new Class<?>[] { | ||
| ShoppingCart.class, | ||
| LineItem.class | ||
| }; | ||
| } | ||
|
|
||
| @After | ||
| public void cleanup() { | ||
| Session s = openSession(); | ||
| s.getTransaction().begin(); | ||
| s.createQuery( "delete from LineItem" ).executeUpdate(); | ||
| s.createQuery( "delete from Cart" ).executeUpdate(); | ||
| s.getTransaction().commit(); | ||
| s.close(); | ||
| } | ||
|
|
||
| @Test | ||
| @TestForIssue(jiraKey = "HHH-11328") | ||
| public void testMergeTransientIdManyToOne() throws Exception { | ||
| ShoppingCart transientCart = new ShoppingCart( "cart1" ); | ||
| transientCart.addLineItem( new LineItem( 0, "description2", transientCart ) ); | ||
|
|
||
| // merge ID with transient many-to-one | ||
| Session s = openSession(); | ||
| s.getTransaction().begin(); | ||
| s.merge( transientCart ); | ||
| s.getTransaction().commit(); | ||
| s.close(); | ||
|
|
||
| s = openSession(); | ||
| s.getTransaction().begin(); | ||
| ShoppingCart updatedCart = s.get( ShoppingCart.class, "cart1" ); | ||
| assertEquals( 1, updatedCart.getLineItems().size() ); | ||
| assertEquals( "description2", updatedCart.getLineItems().get( 0 ).getDescription() ); | ||
| s.getTransaction().commit(); | ||
| s.close(); | ||
| } | ||
|
|
||
| @Test | ||
| @TestForIssue(jiraKey = "HHH-10623") | ||
| public void testMergeDetachedIdManyToOne() throws Exception { | ||
| ShoppingCart cart = new ShoppingCart("cart1"); | ||
|
|
||
| Session s = openSession(); | ||
| s.getTransaction().begin(); | ||
| s.persist( cart ); | ||
| s.getTransaction().commit(); | ||
| s.close(); | ||
|
|
||
| // cart is detached now | ||
| LineItem lineItem = new LineItem( 0, "description2", cart ); | ||
| cart.addLineItem( lineItem ); | ||
|
|
||
| // merge lineItem with an ID with detached many-to-one | ||
| s = openSession(); | ||
| s.getTransaction().begin(); | ||
| s.merge(lineItem); | ||
| s.getTransaction().commit(); | ||
| s.close(); | ||
|
|
||
| s = openSession(); | ||
| s.getTransaction().begin(); | ||
| ShoppingCart updatedCart = s.get( ShoppingCart.class, "cart1" ); | ||
| assertEquals( 1, updatedCart.getLineItems().size() ); | ||
| assertEquals("description2", updatedCart.getLineItems().get( 0 ).getDescription()); | ||
| s.getTransaction().commit(); | ||
| s.close(); | ||
| } | ||
|
|
||
| @Entity(name = "Cart") | ||
| public static class ShoppingCart { | ||
| @Id | ||
| @Column(name = "id", nullable = false) | ||
| private String id; | ||
|
|
||
| @OneToMany(mappedBy = "cart", cascade = CascadeType.ALL, orphanRemoval = true) | ||
| private List<LineItem> lineItems = new ArrayList<>(); | ||
|
|
||
| protected ShoppingCart() { | ||
| } | ||
|
|
||
| public ShoppingCart(String id) { | ||
| this.id = id; | ||
| } | ||
|
|
||
| public List<LineItem> getLineItems() { | ||
| return lineItems; | ||
| } | ||
|
|
||
| public void addLineItem(LineItem lineItem) { | ||
| lineItems.add(lineItem); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
| ShoppingCart that = (ShoppingCart) o; | ||
| return Objects.equals( id, that.id ); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(id); | ||
| } | ||
| } | ||
|
|
||
| @Entity(name = "LineItem") | ||
| @IdClass(LineItem.Pk.class) | ||
| public static class LineItem { | ||
|
|
||
| @Id | ||
| @Column(name = "item_seq_number", nullable = false) | ||
| private Integer sequenceNumber; | ||
|
|
||
| @Column(name = "description") | ||
| private String description; | ||
|
|
||
| @Id | ||
| @ManyToOne | ||
| @JoinColumn(name = "cart_id") | ||
| private ShoppingCart cart; | ||
|
|
||
| protected LineItem() { | ||
| } | ||
|
|
||
| public LineItem(Integer sequenceNumber, String description, ShoppingCart cart) { | ||
| this.sequenceNumber = sequenceNumber; | ||
| this.description = description; | ||
| this.cart = cart; | ||
| } | ||
|
|
||
| public Integer getSequenceNumber() { | ||
| return sequenceNumber; | ||
| } | ||
|
|
||
| public ShoppingCart getCart() { | ||
| return cart; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (!(o instanceof LineItem)) return false; | ||
| LineItem lineItem = (LineItem) o; | ||
| return Objects.equals(getSequenceNumber(), lineItem.getSequenceNumber()) && | ||
| Objects.equals(getCart(), lineItem.getCart()); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash( getSequenceNumber(), getCart() ); | ||
| } | ||
|
|
||
| public String getDescription() { | ||
| return description; | ||
| } | ||
|
|
||
| public static class Pk implements Serializable { | ||
| public Integer sequenceNumber; | ||
| public String cart; | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (!(o instanceof Pk)) return false; | ||
| Pk pk = (Pk) o; | ||
| return Objects.equals(sequenceNumber, pk.sequenceNumber) && | ||
| Objects.equals(cart, pk.cart); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(sequenceNumber, cart); | ||
| } | ||
| } | ||
| } | ||
| } |