Removed Dialect#areStringComparisonsCaseInsensitive() method

hibernate · Sep 25, 2021 · 573d146 · 573d146
1 parent ca83c6c
commit 573d146
Show file tree

Hide file tree

Showing 9 changed files with 3 additions and 64 deletions.
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CacheDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CacheDialect.java
@@ -397,11 +397,6 @@ public boolean supportsEmptyInList() {
 		return false;
 	}
 
-	@Override
-	public boolean areStringComparisonsCaseInsensitive() {
-		return true;
-	}
-
 	@Override
 	public boolean supportsOrderByInSubquery() {
 		// This is just a guess

diff --git a/...ate-community-dialects/src/main/java/org/hibernate/community/dialect/TeradataDialect.java b/...ate-community-dialects/src/main/java/org/hibernate/community/dialect/TeradataDialect.java
@@ -341,11 +341,6 @@ public boolean supportsExistsInSelect() {
 		return false;
 	}
 
-	@Override
-	public boolean areStringComparisonsCaseInsensitive() {
-		return getVersion() < 14;
-	}
-
 	@Override
 	public boolean supportsEmptyInList() {
 		return false;

diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java
@@ -2930,18 +2930,6 @@ public boolean supportsEmptyInList() {
 		return true;
 	}
 
-	/**
-	 * Are string comparisons implicitly case insensitive.
-	 * <p/>
-	 * In other words, does [where 'XYZ' = 'xyz'] resolve to true?
-	 *
-	 * @return True if comparisons are case insensitive.
-	 * @since 3.2
-	 */
-	public boolean areStringComparisonsCaseInsensitive() {
-		return false;
-	}
-
 	/**
 	 * Is this dialect known to support what ANSI-SQL terms "row value
 	 * constructor" syntax; sometimes called tuple syntax.

diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java
@@ -787,11 +787,6 @@ public boolean supportsEmptyInList() {
 		return false;
 	}
 
-	@Override
-	public boolean areStringComparisonsCaseInsensitive() {
-		return true;
-	}
-
 	@Override
 	public boolean supportsLobValueChangePropagation() {
 		// note: at least my local MySQL 5.1 install shows this not working...

diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/SQLServerDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/SQLServerDialect.java
@@ -387,11 +387,6 @@ public String getCurrentTimestampSelectString() {
 
 	// Overridden informational metadata ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-	@Override
-	public boolean areStringComparisonsCaseInsensitive() {
-		return true;
-	}
-
 	@Override
 	public boolean supportsResultSetPositionQueryMethodsOnForwardOnlyCursor() {
 		return false;

diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/SybaseASEDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/SybaseASEDialect.java
@@ -482,19 +482,6 @@ public int getMaxAliasLength() {
 		return 30;
 	}
 
-	/**
-	 * By default, Sybase string comparisons are case-insensitive.
-	 * <p/>
-	 * If the DB is configured to be case-sensitive, then this return
-	 * value will be incorrect.
-	 * <p/>
-	 * {@inheritDoc}
-	 */
-	@Override
-	public boolean areStringComparisonsCaseInsensitive() {
-		return true;
-	}
-
 	@Override
 	@SuppressWarnings("deprecation")
 	public String getCurrentTimestampSQLFunctionName() {

diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/querycache/QueryCacheTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/querycache/QueryCacheTest.java
@@ -371,15 +371,11 @@ public void testQueryCacheInvalidation(SessionFactoryScope scope) throws Excepti
 	}
 
 	@Test
-	@RequiresDialectFeature(
-			feature = DialectFeatureChecks.CaseSensitiveCheck.class,
-			comment = "i.name='widget' should not match on case sensitive database."
-	)
-	public void testCaseInsensitiveComparison(SessionFactoryScope scope) {
+	public void testComparison(SessionFactoryScope scope) {
 		Item item = new Item();
 		scope.inTransaction(
 				session -> {
-					item.setName( "Widget" );
+					item.setName( "widget" );
 					item.setDescription( "A really top-quality, full-featured widget." );
 					session.save( item );
 				}
@@ -390,7 +386,7 @@ public void testCaseInsensitiveComparison(SessionFactoryScope scope) {
 					List result = session.createQuery( queryString ).list();
 					assertEquals( 1, result.size() );
 					Item i = session.get( Item.class, item.getId() );
-					assertEquals( "Widget", i.getName() );
+					assertEquals( "widget", i.getName() );
 					session.delete( i );
 				}
 		);

diff --git a/hibernate-testing/src/main/java/org/hibernate/testing/DialectChecks.java b/hibernate-testing/src/main/java/org/hibernate/testing/DialectChecks.java
@@ -63,12 +63,6 @@ public boolean isMatch(Dialect dialect) {
 		}
 	}
 
-	public static class CaseSensitiveCheck implements DialectCheck {
-		public boolean isMatch(Dialect dialect) {
-			return dialect.areStringComparisonsCaseInsensitive();
-		}
-	}
-
 	public static class SupportsResultSetPositioningOnForwardOnlyCursorCheck implements DialectCheck {
 		public boolean isMatch(Dialect dialect) {
 			return dialect.supportsResultSetPositionQueryMethodsOnForwardOnlyCursor();

diff --git a/hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java b/hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java
@@ -80,12 +80,6 @@ public boolean apply(Dialect dialect) {
 		}
 	}
 
-	public static class CaseSensitiveCheck implements DialectFeatureCheck {
-		public boolean apply(Dialect dialect) {
-			return dialect.areStringComparisonsCaseInsensitive();
-		}
-	}
-
 	public static class SupportsNoColumnInsert implements DialectFeatureCheck {
 		public boolean apply(Dialect dialect) {
 			return dialect.supportsNoColumnsInsert();