HHH-13450 Do not compute the full role name of a collection unless ne…

…cessary
hibernate · Jun 24, 2019 · 7309cde · 7309cde
1 parent e133867
commit 7309cde
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/hibernate-core/src/main/java/org/hibernate/engine/internal/TwoPhaseLoad.java b/hibernate-core/src/main/java/org/hibernate/engine/internal/TwoPhaseLoad.java
@@ -313,7 +313,7 @@ private static Boolean getOverridingEager(
 			String associationName,
 			Type type) {
 		if ( type.isAssociationType() || type.isCollectionType() ) {
-			Boolean overridingEager = isEagerFetchProfile( session, entityName + "." + associationName );
+			Boolean overridingEager = isEagerFetchProfile( session, entityName, associationName );
 
 			if ( LOG.isDebugEnabled() ) {
 				if ( overridingEager != null ) {
@@ -331,14 +331,19 @@ private static Boolean getOverridingEager(
 		return null;
 	}
 
-	private static Boolean isEagerFetchProfile(SharedSessionContractImplementor session, String role) {
+	private static Boolean isEagerFetchProfile(SharedSessionContractImplementor session, String entityName, String associationName) {
 		LoadQueryInfluencers loadQueryInfluencers = session.getLoadQueryInfluencers();
 
-		for ( String fetchProfileName : loadQueryInfluencers.getEnabledFetchProfileNames() ) {
-			FetchProfile fp = session.getFactory().getFetchProfile( fetchProfileName );
-			Fetch fetch = fp.getFetchByRole( role );
-			if ( fetch != null && Fetch.Style.JOIN == fetch.getStyle() ) {
-				return true;
+		// Performance: avoid concatenating entityName + "." + associationName when there is no need,
+		// as otherwise this section becomes an hot allocation point.
+		if ( loadQueryInfluencers.hasEnabledFetchProfiles() ) {
+			final String role =  entityName + '.' + associationName;
+			for ( String fetchProfileName : loadQueryInfluencers.getEnabledFetchProfileNames() ) {
+				FetchProfile fp = session.getFactory().getFetchProfile( fetchProfileName );
+				Fetch fetch = fp.getFetchByRole( role );
+				if ( fetch != null && Fetch.Style.JOIN == fetch.getStyle() ) {
+					return true;
+				}
 			}
 		}
 

diff --git a/hibernate-core/src/main/java/org/hibernate/loader/AbstractEntityJoinWalker.java b/hibernate-core/src/main/java/org/hibernate/loader/AbstractEntityJoinWalker.java
@@ -151,7 +151,7 @@ protected final boolean isJoinFetchEnabledByProfile(OuterJoinLoadable persister,
 		String relativePropertyPath = pos >= 0
 				? fullPath.substring( pos )
 				: rootPropertyName;
-		String fetchRole = persister.getEntityName() + "." + relativePropertyPath;
+		String fetchRole = persister.getEntityName() + '.' + relativePropertyPath;
 
 		for ( String profileName : getLoadQueryInfluencers().getEnabledFetchProfileNames() ) {
 			final FetchProfile profile = getFactory().getFetchProfile( profileName );

diff --git a/...nate-core/src/main/java/org/hibernate/persister/walking/internal/FetchStrategyHelper.java b/...nate-core/src/main/java/org/hibernate/persister/walking/internal/FetchStrategyHelper.java
@@ -58,7 +58,7 @@ public static FetchStyle determineFetchStyleByProfile(
 		final String relativePropertyPath = pos >= 0
 				? fullPath.substring( pos )
 				: rootPropertyName;
-		final String fetchRole = persister.getEntityName() + "." + relativePropertyPath;
+		final String fetchRole = persister.getEntityName() + '.' + relativePropertyPath;
 
 		for ( String profileName : loadQueryInfluencers.getEnabledFetchProfileNames() ) {
 			final FetchProfile profile = loadQueryInfluencers.getSessionFactory().getFetchProfile( profileName );