HHH-13478 Avoiding some duplicate getter executions in DynamicBatchin…

…gEntityLoaderBuilder
hibernate · Jul 2, 2019 · 8e3660b · 8e3660b
1 parent 727dac4
commit 8e3660b
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/...te-core/src/main/java/org/hibernate/loader/entity/DynamicBatchingEntityLoaderBuilder.java b/...te-core/src/main/java/org/hibernate/loader/entity/DynamicBatchingEntityLoaderBuilder.java
@@ -19,6 +19,8 @@
 import org.hibernate.LockOptions;
 import org.hibernate.dialect.pagination.LimitHelper;
 import org.hibernate.engine.internal.BatchFetchQueueHelper;
+import org.hibernate.engine.jdbc.spi.JdbcCoordinator;
+import org.hibernate.engine.jdbc.spi.JdbcServices;
 import org.hibernate.engine.spi.EntityEntry;
 import org.hibernate.engine.spi.EntityKey;
 import org.hibernate.engine.spi.LoadQueryInfluencers;
@@ -443,12 +445,13 @@ public List doEntityBatchFetch(
 				SharedSessionContractImplementor session,
 				QueryParameters queryParameters,
 				Serializable[] ids) {
+			final JdbcServices jdbcServices = session.getJdbcServices();
 			final String sql = StringHelper.expandBatchIdPlaceholder(
 					sqlTemplate,
 					ids,
 					alias,
 					persister.getKeyColumnNames(),
-					session.getJdbcServices().getJdbcEnvironment().getDialect()
+					jdbcServices.getJdbcEnvironment().getDialect()
 			);
 
 			try {
@@ -483,7 +486,7 @@ public List doEntityBatchFetch(
 				}
 			}
 			catch ( SQLException sqle ) {
-				throw session.getJdbcServices().getSqlExceptionHelper().convert(
+				throw jdbcServices.getSqlExceptionHelper().convert(
 						sqle,
 						"could not load an entity batch: " + MessageHelper.infoString(
 								getEntityPersisters()[0],
@@ -509,8 +512,9 @@ private List doTheLoad(String sql, QueryParameters queryParameters, SharedSessio
 				return processResultSet( rs, queryParameters, session, false, null, maxRows, afterLoadActions );
 			}
 			finally {
-				session.getJdbcCoordinator().getLogicalConnection().getResourceRegistry().release( st );
-				session.getJdbcCoordinator().afterStatementExecution();
+				final JdbcCoordinator jdbcCoordinator = session.getJdbcCoordinator();
+				jdbcCoordinator.getLogicalConnection().getResourceRegistry().release( st );
+				jdbcCoordinator.afterStatementExecution();
 			}
 		}
 	}