Skip to content

Commit

Permalink
HHH-12695 Add missing @OVERRIDES in subclasses of javax.persistence.P…
Browse files Browse the repository at this point in the history
…arameter

Because we are in 2018 and Java 5 is now 14 years old.
  • Loading branch information
yrodiere authored and gsmet committed Jul 11, 2018
1 parent 66d123b commit 99c0c32
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 0 deletions.
Expand Up @@ -30,6 +30,7 @@ public NamedParameterDescriptor(String name, Type expectedType, int[] sourceLoca
this.name = name;
}

@Override
public String getName() {
return name;
}
Expand Down
Expand Up @@ -25,6 +25,7 @@ public interface ParameterRegistration<T> extends ProcedureParameter<T> {
*
* @return The name;
*/
@Override
String getName();

/**
Expand All @@ -33,6 +34,7 @@ public interface ParameterRegistration<T> extends ProcedureParameter<T> {
*
* @return The name;
*/
@Override
Integer getPosition();

/**
Expand All @@ -41,6 +43,7 @@ public interface ParameterRegistration<T> extends ProcedureParameter<T> {
*
* @return The parameter mode.
*/
@Override
ParameterMode getMode();

/**
Expand All @@ -59,6 +62,7 @@ public interface ParameterRegistration<T> extends ProcedureParameter<T> {
*
* @param enabled {@code true} indicates that the NULL should be passed; {@code false} indicates it should not.
*/
@Override
void enablePassingNulls(boolean enabled);

/**
Expand Down
Expand Up @@ -46,6 +46,7 @@ public interface ParameterRegistrationImplementor<T> extends ParameterRegistrati
* that the parameter will simply be ignored, with the assumption that the corresponding argument
* defined a default value.
*/
@Override
boolean isPassNullsEnabled();

/**
Expand Down
Expand Up @@ -52,22 +52,27 @@ public ParameterExpressionImpl(
this.position = null;
}

@Override
public String getName() {
return name;
}

@Override
public Integer getPosition() {
return position;
}

@Override
public Class<T> getParameterType() {
return getJavaType();
}

@Override
public void registerParameters(ParameterRegistry registry) {
registry.registerParameter( this );
}

@Override
public String render(RenderingContext renderingContext) {
final ExplicitParameterInfo parameterInfo = renderingContext.registerExplicitParameter( this );
return parameterInfo.render();
Expand Down
Expand Up @@ -39,6 +39,7 @@ public Integer getPosition() {
return null;
}

@Override
public int[] getSourceLocations() {
return sourceLocations;
}
Expand Down
Expand Up @@ -308,6 +308,7 @@ private boolean canDoNameParameterBinding(Type hibernateType) {
&& ((ProcedureParameterNamedBinder) hibernateType).canDoSetting();
}

@Override
public int[] getSqlTypes() {
if ( mode == ParameterMode.REF_CURSOR ) {
// we could use the Types#REF_CURSOR added in Java 8, but that would require requiring Java 8...
Expand Down

0 comments on commit 99c0c32

Please sign in to comment.