Skip to content

Commit

Permalink
HHH-7693 Formatting and duplicate code
Browse files Browse the repository at this point in the history
  • Loading branch information
brmeyer committed Oct 22, 2012
1 parent 0916baf commit b676356
Showing 1 changed file with 108 additions and 102 deletions.
210 changes: 108 additions & 102 deletions ...src/test/java/org/hibernate/engine/jdbc/dialect/internal/StandardDialectResolverTest.java
View file
Expand Up @@ -3,7 +3,7 @@
*
* Copyright (c) 2008, Red Hat Middleware LLC or third-party contributors as
* indicated by the @author tags or express copyright attribution
* statements applied by the authors. All third-party contributions are
* statements applied by the authors. All third-party contributions are
* distributed under license by Red Hat Middleware LLC.
*
* This copyrighted material is made available to anyone wishing to use, modify,
Expand All @@ -12,14 +12,14 @@
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
* for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this distribution; if not, write to:
* Free Software Foundation, Inc.
* 51 Franklin Street, Fifth Floor
* Boston, MA 02110-1301 USA
* Boston, MA 02110-1301 USA
*
*/
package org.hibernate.engine.jdbc.dialect.internal;
Expand Down Expand Up @@ -49,102 +49,108 @@
*/
public class StandardDialectResolverTest extends BaseUnitTestCase {

@Test
public void testResolveDialectInternalForSQLServer2000() throws SQLException {
runSQLServerDialectTest(8, SQLServerDialect.class);
}

@Test
public void testResolveDialectInternalForSQLServer2005() throws SQLException {
runSQLServerDialectTest(9, SQLServer2005Dialect.class);
}

@Test
public void testResolveDialectInternalForSQLServer2008() throws SQLException {
runSQLServerDialectTest(10, SQLServer2008Dialect.class);
}

@Test
public void testResolveDialectInternalForSQLServer2012() throws SQLException {
runSQLServerDialectTest(11, SQLServer2008Dialect.class);
}

@Test
public void testResolveDialectInternalForUnknownSQLServerVersion() throws SQLException {
runSQLServerDialectTest(7, SQLServerDialect.class);
}

@Test
public void testResolveDialectInternalForPostgres81() throws SQLException {
runPostgresDialectTest(8, 1, PostgreSQL81Dialect.class);
}

@Test
public void testResolveDialectInternalForPostgres82() throws SQLException {
runPostgresDialectTest(8, 2, PostgreSQL82Dialect.class);
}

@Test
public void testResolveDialectInternalForPostgres83() throws SQLException {
runPostgresDialectTest(8, 3, PostgreSQL82Dialect.class);
}

@Test
public void testResolveDialectInternalForPostgres84() throws SQLException {
runPostgresDialectTest(8, 4, PostgreSQL82Dialect.class);
}

@Test
public void testResolveDialectInternalForPostgres9() throws SQLException {
runPostgresDialectTest(9, 0, PostgreSQL82Dialect.class);
}

@Test
public void testResolveDialectInternalForPostgres91() throws SQLException {
runPostgresDialectTest(9, 1, PostgreSQL82Dialect.class);
}

@Test
public void testResolveDialectInternalForPostgres92() throws SQLException {
runPostgresDialectTest(9, 2, PostgreSQL82Dialect.class);
}

private static void runSQLServerDialectTest(int version, Class<? extends SQLServerDialect> expectedDialect)
throws SQLException {
DatabaseMetaData metaData = mock(DatabaseMetaData.class);
when(metaData.getDatabaseProductName()).thenReturn("Microsoft SQL Server");
when(metaData.getDatabaseMajorVersion()).thenReturn(version);

Dialect dialect = new StandardDialectResolver().resolveDialect(metaData);
assertNotNull("Dialect for SQL Server version " + version + " should not be null", dialect);
assertTrue("Dialect for SQL Server version " + version + " should be " + expectedDialect.getSimpleName(),
expectedDialect.isInstance(dialect));
}

private static void runPostgresDialectTest(int majorVersion, int minorVersion,
Class<? extends Dialect> expectedDialect) throws SQLException {
runDialectTest("PostgreSQL", majorVersion, minorVersion, expectedDialect);
}

private static void runDialectTest(String productName, int majorVersion, int minorVersion,
Class<? extends Dialect> expectedDialect) throws SQLException {
DatabaseMetaData metaData = mock(DatabaseMetaData.class);
when(metaData.getDatabaseProductName()).thenReturn(productName);
when(metaData.getDatabaseMajorVersion()).thenReturn(majorVersion);
when(metaData.getDatabaseMinorVersion()).thenReturn(minorVersion);

Dialect dialect = new StandardDialectResolver().resolveDialect(metaData);

StringBuilder builder = new StringBuilder(productName)
.append(" ")
.append(majorVersion);
if (minorVersion > 0) {
builder.append(".").append(minorVersion);
}
String dbms = builder.toString();

assertNotNull("Dialect for " + dbms + " should not be null", dialect);
assertTrue("Dialect for " + dbms + " should be " + expectedDialect.getSimpleName(),
expectedDialect.isInstance(dialect));
}
}
@Test
public void testResolveDialectInternalForSQLServer2000()
throws SQLException {
runSQLServerDialectTest( 8, SQLServerDialect.class );
}

@Test
public void testResolveDialectInternalForSQLServer2005()
throws SQLException {
runSQLServerDialectTest( 9, SQLServer2005Dialect.class );
}

@Test
public void testResolveDialectInternalForSQLServer2008()
throws SQLException {
runSQLServerDialectTest( 10, SQLServer2008Dialect.class );
}

@Test
public void testResolveDialectInternalForSQLServer2012()
throws SQLException {
runSQLServerDialectTest( 11, SQLServer2008Dialect.class );
}

@Test
public void testResolveDialectInternalForUnknownSQLServerVersion()
throws SQLException {
runSQLServerDialectTest( 7, SQLServerDialect.class );
}

@Test
public void testResolveDialectInternalForPostgres81()
throws SQLException {
runPostgresDialectTest( 8, 1, PostgreSQL81Dialect.class );
}

@Test
public void testResolveDialectInternalForPostgres82()
throws SQLException {
runPostgresDialectTest( 8, 2, PostgreSQL82Dialect.class );
}

@Test
public void testResolveDialectInternalForPostgres83() throws SQLException {
runPostgresDialectTest( 8, 3, PostgreSQL82Dialect.class );
}

@Test
public void testResolveDialectInternalForPostgres84() throws SQLException {
runPostgresDialectTest( 8, 4, PostgreSQL82Dialect.class );
}

@Test
public void testResolveDialectInternalForPostgres9() throws SQLException {
runPostgresDialectTest( 9, 0, PostgreSQL82Dialect.class );
}

@Test
public void testResolveDialectInternalForPostgres91() throws SQLException {
runPostgresDialectTest( 9, 1, PostgreSQL82Dialect.class );
}

@Test
public void testResolveDialectInternalForPostgres92() throws SQLException {
runPostgresDialectTest( 9, 2, PostgreSQL82Dialect.class );
}

private static void runSQLServerDialectTest(
int version, Class<? extends SQLServerDialect> expectedDialect)
throws SQLException {
runDialectTest( "Microsoft SQL Server", version, 0,
expectedDialect );
}

private static void runPostgresDialectTest(
int majorVersion, int minorVersion,
Class<? extends Dialect> expectedDialect) throws SQLException {
runDialectTest( "PostgreSQL", majorVersion, minorVersion,
expectedDialect );
}

private static void runDialectTest(
String productName, int majorVersion, int minorVersion,
Class<? extends Dialect> expectedDialect) throws SQLException {
DatabaseMetaData metaData = mock( DatabaseMetaData.class );
when( metaData.getDatabaseProductName() ).thenReturn( productName );
when( metaData.getDatabaseMajorVersion() ).thenReturn( majorVersion );
when( metaData.getDatabaseMinorVersion() ).thenReturn( minorVersion );

Dialect dialect = new StandardDialectResolver().resolveDialect(
metaData );

StringBuilder builder = new StringBuilder( productName ).append( " " )
.append( majorVersion );
if ( minorVersion > 0 ) {
builder.append( "." ).append( minorVersion );
}
String dbms = builder.toString();

assertNotNull( "Dialect for " + dbms + " should not be null", dialect );
assertTrue( "Dialect for " + dbms + " should be "
+ expectedDialect.getSimpleName(),
expectedDialect.isInstance( dialect ) );
}
}

0 comments on commit b676356

Please sign in to comment.