Fix file descriptor leak

hibernate · Nov 23, 2022 · c6fa10d · c6fa10d
1 parent 818bb41
commit c6fa10d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/...-core/src/main/java/org/hibernate/tool/schema/internal/exec/ScriptSourceInputFromUrl.java b/...-core/src/main/java/org/hibernate/tool/schema/internal/exec/ScriptSourceInputFromUrl.java
@@ -60,7 +60,7 @@ protected Reader prepareReader() {
 	@Override
 	protected void releaseReader(Reader reader) {
 		try {
-			prepareReader().close();
+			reader.close();
 		}
 		catch (IOException e) {
 			log.warn( "Unable to close file reader for generation script source" );

diff --git a/...core/src/test/java/org/hibernate/orm/test/tool/schema/DefaultImportFileExecutionTest.java b/...core/src/test/java/org/hibernate/orm/test/tool/schema/DefaultImportFileExecutionTest.java
@@ -2,7 +2,9 @@
 
 import java.io.File;
 import java.io.FileWriter;
+import java.io.IOException;
 import java.net.URL;
+import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.EnumSet;
 import java.util.HashMap;
@@ -56,7 +58,12 @@ public void setUp() throws Exception {
 	public void tearDown() {
 		serviceRegistry.close();
 		if ( defaultImportFile.exists() ) {
-			defaultImportFile.delete();
+			try {
+				Files.delete( defaultImportFile.toPath() );
+			}
+			catch (IOException e) {
+				throw new RuntimeException( e );
+			}
 		}
 	}