Code Clean up

hibernate · Feb 17, 2020 · cb5fe26 · cb5fe26
1 parent c488735
commit cb5fe26
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java b/hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java
@@ -450,9 +450,7 @@ public boolean isSimpleValue() {
 	}
 
 	public boolean isValid(Mapping mapping) throws MappingException {
-		int columnSpan = getColumnSpan();
-		int typeColumnSpan = getType().getColumnSpan( mapping );
-		return columnSpan == typeColumnSpan;
+		return getColumnSpan() == getType().getColumnSpan( mapping );
 	}
 
 //	public Type getType() throws MappingException {

diff --git a/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/EmbeddableMappingType.java b/hibernate-core/src/main/java/org/hibernate/metamodel/mapping/EmbeddableMappingType.java
@@ -178,11 +178,6 @@ else if ( subtype instanceof CompositeType ) {
 					);
 				}
 				else if ( subtype instanceof EntityType ) {
-					final Dialect dialect = creationProcess.getCreationContext()
-							.getSessionFactory()
-							.getJdbcServices()
-							.getDialect();
-
 					final SingularAssociationAttributeMapping singularAssociationAttributeMapping = MappingModelCreationHelper.buildSingularAssociationAttributeMapping(
 							bootPropertyDescriptor.getName(),
 							attributeIndex,