HHH-17445 Don't force initialization of correlated joined table group

hibernate · Dec 1, 2023 · e0875a1 · e0875a1
1 parent 314c621
commit e0875a1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java b/hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java
@@ -3786,8 +3786,6 @@ private TableGroup createTableGroup(TableGroup parentTableGroup, SqmPath<?> join
 						querySpec::applyPredicate,
 						this
 				);
-				// Force initialization of a possible lazy table group
-				tableGroup.getPrimaryTableReference();
 				querySpec.getFromClause().addRoot( tableGroup );
 			}
 			else {

diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/query/ImplicitJoinInSubqueryTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/query/ImplicitJoinInSubqueryTest.java
@@ -18,7 +18,6 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-@JiraKey("HHH-16721")
 @DomainModel(annotatedClasses = {
         ImplicitJoinInSubqueryTest.A.class,
         ImplicitJoinInSubqueryTest.B.class,
@@ -28,6 +27,7 @@
 public class ImplicitJoinInSubqueryTest {
 
     @Test
+    @JiraKey("HHH-16721")
     public void testImplicitJoinInSubquery(SessionFactoryScope scope) {
         SQLStatementInspector statementInspector = scope.getCollectingStatementInspector();
         statementInspector.clear();
@@ -41,6 +41,22 @@ public void testImplicitJoinInSubquery(SessionFactoryScope scope) {
         );
     }
 
+    @Test
+    @JiraKey("HHH-17445")
+    public void testImplicitJoinInSubquery2(SessionFactoryScope scope) {
+        SQLStatementInspector statementInspector = scope.getCollectingStatementInspector();
+        statementInspector.clear();
+        scope.inTransaction(
+                entityManager -> {
+                    entityManager.createSelectionQuery(
+                            "select a from A a where exists (select 1 from B b where a.b.c is null)"
+                    ).getResultList();
+                    assertThat( statementInspector.getSqlQueries().get( 0 ) ).contains( "b1_0.c_id is null" );
+                    assertThat( statementInspector.getSqlQueries().get( 0 ) ).doesNotContain( ".id=b1_0.c_id" );
+                }
+        );
+    }
+
     @Entity(name = "A")
     public static class A {
         @Id