HHH-13133 #2941
Closed
HHH-13133 #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt of logging under non-debug mode
Sanne
requested changes
Aug 2, 2019
| @@ -157,7 +157,7 @@ public boolean doExtendedEnhancement(UnloadedClass classDescriptor) { | |||
|
|
|||
| writeOutEnhancedClass( enhancedBytecode, file ); | |||
|
|
|||
| getLog().info( "Successfully enhanced class [" + file + "]" ); | |||
There was a problem hiding this comment.
could you change this to make sure the strings aren't appended when the logger is not set to debug?
Something like
log = getLog()
if (log.isDebugEnabled()) { log.debug( .... ) }
There was a problem hiding this comment.
I will make the change and submit another PR.
|
Many thanks! Only had a very minor comment, if you could address that I'll merge it right away. Generally speaking, try to not include unrelated changes in the same commit / same JIRA id.. but it's fine since they are very minor. |
|
merged it. Thanks! |
|
Thanks for merging Sanne. Strangely I didn't get any notification for the last 4 days. |
|
@skis no worries, and no need to make another PR as I already changed it! Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to HHH-13133