HHH-11797 Add support for @MapKeyEnumerated mappings #3044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naros
force-pushed
the
HHH-11797
branch
2 times, most recently
from
a46e6f1
to
7a8260c
Compare
dreab8
reviewed
Sep 27, 2019
...ibernate/envers/internal/entities/mapper/relation/MiddleMapKeyEnumeratedComponentMapper.java
Show resolved
Hide resolved
dreab8
reviewed
Sep 27, 2019
...n/java/org/hibernate/envers/configuration/internal/metadata/CollectionMetadataGenerator.java
Outdated
Show resolved
Hide resolved
dreab8
reviewed
Sep 27, 2019
...nvers/src/main/java/org/hibernate/envers/internal/entities/mapper/relation/MiddleIdData.java
Outdated
Show resolved
Hide resolved
|
Hi @dreab8, I'll double check your comments. If I can't see any reason why they should be there I'll change the code and push to the PR so you can make the release this weekend. |
|
@dreab8 Great catches on all fronts, fixed the changes as suggested, rebased and squashed. It should be all set for merging if CI passes. |
|
thanks @Naros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-11797