wip/6.0 HHH-13937 Get rid of junit5 compile-time dependencies #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
force-pushed
the
HHH-13937
branch
from
2838586
to
ba71111
Compare
NathanQingyangXu
force-pushed
the
HHH-13937
branch
from
ba71111
to
1ab9412
Compare
NathanQingyangXu
changed the title
dreab8
reviewed
Apr 14, 2020
| testRuntime(libraries.wildfly_transaction_client) | ||
| testRuntime( libraries.wildfly_transaction_client ) | ||
| testRuntime( libraries.junit5_vintage ) | ||
| testRuntime( libraries.junit5_jupiter ) | ||
|
|
There was a problem hiding this comment.
they can be removed, the correct dependencies are already declared in java-module.gradle
|
@NathanQingyangXu thanks for the PR, I created this one #3339 where I just remove the dependencies causing the issue, what do you think? |
|
I think your PR is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-13937
The root cause that junit-jupiter and junit-vintage show up as compile time dependencies is they are specified as
runtimedependency. They should be specified astestRuntimeinstead (see https://www.petrikainulainen.net/programming/testing/junit-5-tutorial-running-unit-tests-with-gradle/, e.g.).