HHH-13959 - Add nullability and uniqueness for @OneToOne with @JoinTable

[dreab8]

https://hibernate.atlassian.net/browse/HHH-13959

[pdinc-oss]

much, much nicer than our mess from 4AM.

[NathanQingyangXu]

I understand you wanna avoid a temporary variable for makePropertyAndBind() result, but it is still a little bit confusing why propertyBinder.makePropertyAndBind() remains the same across the two if blocks.

Maybe the following refactoring is a little bit better in terms of code readability

final Property boundProperty = propertyBinder.makePropertyAndBind();
if ( property.isAnnotationPresent( JoinTable.class ) ) {
    boundProperty.setOptional( optional );
}

Not a big deal and feel free to ignore my comment.

[dreab8]

Thanks @NathanQingyangXu , I have applied your suggestion.

[jwgmeligmeyling]

Any particular reason why this clause differs from the case with the JoinTable? It would seem only sensible that the optionality is always relevant for the bound property. I trust that it is not, but then I am somewhat surprised that this is an appropriate fix 😉

[pdinc-oss]

This patch is a bit different than the one I wrote, i'll look at it.

[pdinc-oss]

A quick look at it, the bindManyToOne method may be used outside of the JoinTable situation, so setting optional would be disallowed. Also not all usage of JoinTable gets you to this code, there has to be a OneToOne.

[dreab8]

Hi @jwgmeligmeyling I'm looking at the issue again, and I tend to agree with you.

The problem with just setting propertyBinder.makePropertyAndBind().setOptional( optional ); is for cases like the one in NonNullableCircularDependencyCascadeTest where we have

@Entity
public class Child
{
   ...

   @ManyToOne(cascade=CascadeType.PERSIST)
   @JoinColumn(name="parentId", nullable=false)
	Parent parent; 
    ...
}

I pushed a slightly different solution.

[jwgmeligmeyling]

Looks good to me!

[dreab8]

Thanks @jwgmeligmeyling for the review

[dreab8]

applied upstream