HHH-13975 : geolatte-geom support for SpatialPredicates #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maesenka Would you mind taking a look at this PR? You approved the last PR from the same author previously. |
|
I've added back |
|
Thanks again @NathanQingyangXu and @maesenka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances
SpatialPredicates(added in version5.4.13, see #3159 for the original PR) to supportgeolatte-geom(in addition toJTS).To clearly distinguish the classes, I've renamed
SpatialPredicatestoJTSSpatialPredicates, and added a new classGeolatteSpatialPredicatesforgeolatte-geom.This unfortunately, is a minor breaking change.Please review by commit, else the file renaming will mess with the Diffs.