HHH-14315 Upgrade to Gradle 6.7 and use toolchains for per-JDK builds #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example build with JDK16: https://ci.hibernate.org/view/Personal%20jobs/job/hibernate-orm-personal-yoann-jdk16/12/console |
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Apparently Gradle won't just use the same options as in its own JVM. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
For some reason the gradle build gets stuck at task :hibernate-core:compileTestJava when using OpenJDK 11.0.3. I can't reproduce the problem with 11.0.9, though, so it's probably a bug in OpenJDK 11.0.3. Signed-off-by: Yoann Rodière <yoann@hibernate.org>
Sanne
reviewed
Nov 10, 2020
Sanne
reviewed
Nov 10, 2020
Sanne
approved these changes
Nov 10, 2020
|
Looks great! I'll merge it in master, but defer backporting it a bit. This might allow making some more changes in case there's need for CI setup? @sebersole you might be interested? Much more flexibility and control of JDKs being used for build/release/testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-14315
After this PR, we will need a few change in our CI jobs, and then we will be able to test JDK16 (spoiler alert: it works).
This introduces similar changes to hibernate/hibernate-reactive#429.
By default, nothing changes, except that we now use Gradle 6.7.
When specific options are enabled:
Different configurations are also possible, e.g. run Gradle with JDK11, compile with JDK8 and run the tests with JDK15. But the one above is the most interesting and most likely the one we'll use.
@Sanne I think that, considering you need specific options to enable toolchains, we can safely backport to 5.4?