HHH-16189 wrong order by and group by generated

[dreab8]

https://hibernate.atlassian.net/browse/HHH-16189

[beikov]

You have to add @RequiresDialect(H2Dialect.class) to OrderByAndAggregateFunctionTest because not every database supports functional dependency analysis.

Also, it would be interesting to see what happens if the id attribute is an embeddable.

[dreab8]

yeap. Derby, Oracle, DB2 and SQLServer were failing, they want the id to be present in both the group and order by.

I had also changed https://github.com/hibernate/hibernate-orm/pull/6237/files#diff-d177a632e40c816cc34f0e75e48cfd23535d0f7c626597bfc4adbaf861b72514R79 adding || currentClause == Clause.ORDER || currentClause == Clause.HAVING to avoid failure of queries like

select c.id, sum(p.number) " +
"from Parent p " +
"inner join p.child c " +
"group by c.id " +
"order by c.id

and

"select c.id, sum(p.number) " +
"from Parent p " +
"inner join p.child c " +
"group by c.id " +
"having c.id > 5",

I'm going to check with embeddables

[dreab8]

@beikov added EmbeddedIdOrderByAndAggregateFunctionTest

[beikov]

Looks like EmbeddedIdOrderByAndAggregateFunctionTest is failing on PostgreSQL.