Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-16858 improve typechecking for comparisons/assignments #6910

Merged
merged 3 commits into from
Jun 28, 2023
Merged

HHH-16858 improve typechecking for comparisons/assignments #6910

merged 3 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. HHH-16858 improve typechecking for comparisons/assignments 

    In particular, correctly typecheck comparisons between enums
and other enums, and literal integers / strings. Actually
I'm not a great fan of comparing enums with int/string literals
but since we used to support it in 5, and kinda mostly support
it in earlier releases of 6, on balance we might as well continue
to allow it.
    @gavinking
    gavinking committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0f85c7c View commit details
    Browse the repository at this point in the history

  2. improve typechecking for arguments to min() & max() 

    - use the known JdbcType which previously we didn't have
  proper access to
- and accidentally fix HHH-16859 by side-effect
  (I didn't really want to fix that one, but it was easier
  to fix it than to unfix it.)
    @gavinking
    gavinking committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0e28b24 View commit details
    Browse the repository at this point in the history

  3. HHH-16858 handle MySQL enum types correctly in comparison typecheck

    @gavinking
    gavinking committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    395259b View commit details
    Browse the repository at this point in the history