Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-13741 - LOG_SLOW_QUERY parameter doesn't always log SQL #7030

Merged
merged 1 commit into from Jul 19, 2023

Conversation

sebersole
Copy link
Member

https://hibernate.atlassian.net/browse/HHH-13741

Simpler (and I'd argue more correct) alternative to #5088

@herisson-88
Copy link

Thanks a lot, will improove performance logging of hundreds of ours projets !

@sebersole sebersole merged commit e250464 into hibernate:main Jul 19, 2023
17 of 19 checks passed
@sebersole sebersole deleted the log-slow-query branch July 19, 2023 16:35
@ozkanpakdil
Copy link

ozkanpakdil commented Jul 20, 2023

hey @beikov and @herisson-88
Can you please tell when will this be published ? or which version we will see it ?
Thank you

@herisson-88
Copy link

https://hibernate.atlassian.net/browse/HHH-13741 it's mark next 6.3 I see.

@sebersole
Copy link
Member Author

You can see from the linked Jira it will be in 6.3. I am working on the 6.3 release as we speak.

@hojongs
Copy link

hojongs commented Jul 21, 2023

Hello,
Are there any plans to apply this change in the 5.6.x release?

@LukaszSkowronek
Copy link

Hello, i am using version 6.3.1.Final and it seems like it is not working. I still get Slow query took 130 milliseconds [HikariProxyPreparedStatement@1859255735 wrapping oracle.jdbc.driver.OraclePreparedStatementWrapper@1aaab222]

@beikov
Copy link
Contributor

beikov commented Sep 21, 2023

Hey, there was something missing unfortunately, but I fixed it now: f84c2b5
You'll have to wait until 6.3.2, but it would be nice if you could try the snapshot and confirm it works for you.

@LukaszSkowronek
Copy link

Hey, i will check. Do you know when it will be released?

@beikov
Copy link
Contributor

beikov commented Sep 21, 2023

6.3.1 was just released a few days ago, so it might take a few more days until we cut a 6.3.2 release.

@mpela81
Copy link

mpela81 commented Oct 11, 2023

Hi, When is 6.3.2 release expected to be out? We'd love getting this fix.

@beikov
Copy link
Contributor

beikov commented Oct 11, 2023

By the end of this week or at the start of the next week.

@mpela81
Copy link

mpela81 commented Nov 6, 2023

By the end of this week or at the start of the next week.

Hi, It looks like the plan has changed for 6.3.2 including this fix? Thanks

@mpela81
Copy link

mpela81 commented Nov 15, 2023

Hi @beikov, @sebersole,
Can a 6.3.x stable release be done, including this fix please?
We are undergoing a migration to 6.3.x and require LOG_SLOW_QUERY to work. Waiting for 6.4.x to get this fixed would be quite problematic (and creating our own 6.3.x fork is not really a good option either).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants