HHH-16935 Fix inconsistent method name

[quaff]

https://hibernate.atlassian.net/browse/HHH-16935

[quaff]

@sebersole Please review.

[Sanne]

That looks reasonable, thanks!
I'll let @sebersole decide about the final method name, but could you re-introduce the old method name as a deprecated delegate please? Otherwise I'm not sure which platforms we might break, and we wouldn't want to do that in a micro.

[quaff]

That looks reasonable, thanks! I'll let @sebersole decide about the final method name, but could you re-introduce the old method name as a deprecated delegate please? Otherwise I'm not sure which platforms we might break, and we wouldn't want to do that in a micro.

@Sanne Updated by introducing deprecated default method as your suggestion.

[quaff]

It's not just renaming but also logic error fix, please check it ASAP. @Sanne @sebersole

hibernate-orm/hibernate-core/src/main/java/org/hibernate/boot/internal/MetadataBuilderImpl.java

Lines 973 to 976 in 0897a90

	@Override
	public boolean disallowExtensionsInCdi() {
	return allowExtensionsInCdi;
	}

[gavinking]

This is an extremely awkward-sounding name.

How about something like isCdiIntegrationEnabled(). WDYT, @sebersole?

[quaff]

This is an extremely awkward-sounding name.

How about something like isCdiIntegrationEnabled(). WDYT, @sebersole?

Please keep in mind AvailableSettings.ALLOW_EXTENSIONS_IN_CDI is public, consistency or compatibility will be broken if renaming is made again.

hibernate-orm/hibernate-core/src/main/java/org/hibernate/cfg/AvailableSettings.java

Line 1356 in 0897a90

String ALLOW_EXTENSIONS_IN_CDI = "hibernate.cdi.extensions";

[quaff]

What's the decision?

[sebersole]

Sorry, missed the notifications from this. 👍 Jan is going to rebase this and apply

[jrenaat]

Sorry, missed the notifications from this. 👍 Jan is going to rebase this and apply

Done.

[quaff]

It should be backported to 6.2.x and 6.3.x since it's bugfix.

[mgvinuesa]

Hello, I think this change it is related with this bug

https://hibernate.atlassian.net/jira/software/c/projects/HHH/issues/HHH-16881?filter=allissues

I don't know if you have time to check it, but currently it is not possible to use RevisionListener with Spring Boot 3.1.X

Thanks in advance

[quaff]

Hello, I think this change it is related with this bug

https://hibernate.atlassian.net/jira/software/c/projects/HHH/issues/HHH-16881?filter=allissues

I don't know if you have time to check it, but currently it is not possible to use RevisionListener with Spring Boot 3.1.X

Thanks in advance

I missed checking Helper.allowExtensionsInCdi().

[mgvinuesa]

I created a PR yesterday

#7446