HHH-17377 - Migrate to JPA 3.2 #7494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit fixes SQM/JPA Criteria compile errors. Just Graph compile errors left - only 32! |
beikov
reviewed
Nov 2, 2023
hibernate-core/src/main/java/org/hibernate/engine/spi/SessionDelegatorBaseImpl.java
Outdated
Show resolved
Hide resolved
...te-core/src/main/java/org/hibernate/query/criteria/spi/HibernateCriteriaBuilderDelegate.java
Show resolved
Hide resolved
...te-core/src/main/java/org/hibernate/query/criteria/spi/HibernateCriteriaBuilderDelegate.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmCriteriaNodeBuilder.java
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmCriteriaNodeBuilder.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tree/insert/SqmInsertValuesStatement.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tree/update/SqmUpdateStatement.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tree/update/SqmUpdateStatement.java
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tree/select/SqmSortSpecification.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/spi/QueryProducerImplementor.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @beikov. You caught some tricky ones to track down. I left a few replies |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
sebersole
force-pushed
the
jpa32
branch
2 times, most recently
from
07858f4
to
bc4ab76
Compare
sebersole
force-pushed
the
jpa32
branch
2 times, most recently
from
b3aaecb
to
c4a70f6
Compare
https://hibernate.atlassian.net/browse/HHH-17377 Fixed SQM/JPA Criteria compilation errors. Just Graph left
https://hibernate.atlassian.net/browse/HHH-17377 Just Graph completed - 2 left related to Session/EntityManager
https://hibernate.atlassian.net/browse/HHH-17377 Now on to 73 test compile errors :)
https://hibernate.atlassian.net/browse/HHH-17377 Test compilation success!! 95 test failures next
https://hibernate.atlassian.net/browse/HHH-17377 Test compilation success!! 95 test failures next
https://hibernate.atlassian.net/browse/HHH-17377 Test compilation success!! 95 test failures next
https://hibernate.atlassian.net/browse/HHH-17377 Test compilation success!! 95 test failures next
https://hibernate.atlassian.net/browse/HHH-17377 Test compilation success!! 95 test failures next
https://hibernate.atlassian.net/browse/HHH-17377 Change GitHub workflow to use Java 17
https://hibernate.atlassian.net/browse/HHH-17377 Change GitHub workflow to use Java 17
https://hibernate.atlassian.net/browse/HHH-17377 fixed check failures
https://hibernate.atlassian.net/browse/HHH-17377 XJB changes (JAXB "binding model")
https://hibernate.atlassian.net/browse/HHH-17377 XJB changes (JAXB "binding model")
https://hibernate.atlassian.net/browse/HHH-17377 XJB changes (JAXB "binding model")
https://hibernate.atlassian.net/browse/HHH-17377 XJB changes (JAXB "binding model")
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-17377
https://hibernate.atlassian.net/browse/HHH-17441